used async/syntax for better readability & performance #4144
Conversation
Simplified fetch event handling
| console.log("[PWA Builder] Caching pages during install"); | ||
| return cache.addAll(precacheFiles); | ||
| }) | ||
| ); | ||
| }); | ||
|
|
||
| // Allow sw to control of current page | ||
| self.addEventListener("activate", function (event) { | ||
| // eslint-disable-next-line no-console |
There was a problem hiding this comment.
why did you remove this line?
|
Did I? Let me check
…On Sun, 15 Dec, 2024, 6:27 pm amrit, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In sw.js
<#4144 (comment)>
:
> console.log("[PWA Builder] Caching pages during install");
return cache.addAll(precacheFiles);
})
);
});
-// Allow sw to control of current page
-self.addEventListener("activate", function (event) {
- // eslint-disable-next-line no-console
why did you remove this line?
—
Reply to this email directly, view it on GitHub
<#4144 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6J4JNXZIV3FUICQKS3IBGT2FV4C5AVCNFSM6AAAAABTTWHUB2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBUGU2TCMBRGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Can you please elaborate on the what and why of your changes? |
|
|
you just need to test the file it looks good but attaching a working video of music blocks will be good enough since you have not added any description |
|
Yes. Please explain why and how you tested your changes. |
|
@samar-703 please respond to Walter's comment last month of "Please explain why and how you tested your changes." |
I did not check my tests properly, I am sorry about that, I made a pr too soon. |
it's alright you can convert this into a draft. |
Simplified fetch event handling