Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Avatar and ImageInput components #922
Add Avatar and ImageInput components #922
Changes from all commits
90c4ea6
6e6b5b3
ac2b34d
31fc08b
2ec6862
42a0ca2
4fcd7a0
7ad234b
d074661
2a7d67f
1b96826
b93b5ac
bceaece
0b37bad
dbb4f8c
48fa172
52f3f0f
6817573
a9716ca
e162fe9
4c0a39e
40f10de
a73ffc4
b729518
018f6bf
c2cf4cf
7b825bb
a70e608
1a6fe89
10d54aa
7327509
0ae1158
5950ee9
5727c31
1d4c229
eb3121e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding a dedicated Accessibility section! 🙌🏻
Some feedback: I would flip the order of the recommendations: adding alt text should be the default, omitting it the exception. It's better to have duplicate content than missing content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworded it to put more focus on when the alt text was necessary.
Do you think we should make
alt
a required prop and remove the""
default? In that case developers will need to explicitly pass""
if their images are presentational.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a good idea. It forces developers to make a conscious decision.