-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertex Description of FunctionArray Inputs #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrdie
reviewed
Dec 26, 2023
byrdie
reviewed
Jan 12, 2024
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
byrdie
reviewed
Aug 2, 2024
byrdie
reviewed
Aug 2, 2024
byrdie
reviewed
Aug 2, 2024
byrdie
reviewed
Aug 2, 2024
byrdie
reviewed
Aug 2, 2024
…vertex style inputs.
…the FunctionArray.__call__
…is that doesn't exist in the inputs and vice versa
…de regridding package. Cleaning up print statements.
…hts for compatibility with new broadcasting withint regridding package.
…as intended with vertex style inputs
…imensions in _getitem
3e2bf21
to
44ff03c
Compare
# Conflicts: # named_arrays/regridding.py # pyproject.toml
…ed for passing tests.
byrdie
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A non-exaustive review of functions.py
…ray output allready covered in test_functions.py
…tion loops over the components of values inputs and calls scalar regrid_from_weights
…andle scalar grids.
byrdie
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too enable conservative interpolation of a
FunctionArray
outputs need to be described by an input array of pixel vertices rather than centers. Rather than create a separate histogram class to enable this functionality,FunctionArray
should take both vertices and centers for inputs.