Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add OAuth PKCE #331

Merged
merged 11 commits into from
Nov 1, 2023
Merged

feat: add OAuth PKCE #331

merged 11 commits into from
Nov 1, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Sep 25, 2023 •
edited
Loading

What kind of change does this PR introduce?

To mirror the JS lib. Probably first of a few PRs

cc: @silentworks

@sourcery-ai sourcery-ai bot mentioned this pull request Sep 25, 2023
Merged
@J0
Merge pull request #332 from supabase-community/sourcery/j0/pkce
b331d04 
feat: add OAuth PKCE (Sourcery refactored)
@silentworks silentworks self-requested a review September 26, 2023 10:47
@J0 J0 mentioned this pull request Oct 4, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (160b671) 45.68% compared to head (364292c) 45.37%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   45.68%   45.37%   -0.32%     
==========================================
  Files          23       23              
  Lines        1902     1955      +53     
==========================================
+ Hits          869      887      +18     
- Misses       1033     1068      +35
Files Coverage Δ
gotrue/types.py 99.05% <100.00%> (+0.02%) ⬆️
gotrue/helpers.py 67.53% <46.15%> (-4.35%) ⬇️
gotrue/_async/gotrue_client.py 29.68% <12.50%> (-0.70%) ⬇️
gotrue/_sync/gotrue_client.py 29.68% <12.50%> (-0.70%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J0 J0 marked this pull request as ready for review November 1, 2023 00:01
silentworks
silentworks requested changes Nov 1, 2023
View reviewed changes
gotrue/_async/gotrue_client.py Outdated Show resolved Hide resolved
gotrue/_sync/gotrue_client.py Outdated Show resolved Hide resolved
silentworks
silentworks approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@silentworks silentworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silentworks silentworks merged commit 8fe633e into main Nov 1, 2023
10 of 12 checks passed
@silentworks silentworks deleted the j0/pkce branch November 1, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silentworks silentworks silentworks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J0 @silentworks