fix: add an error code for empty request body

internal/api/admin.go

@@ -514,7 +514,7 @@ func (a *API) adminUserDelete(w http.ResponseWriter, r *http.Request) error {
 	// ShouldSoftDelete defaults to false
 	params := &adminUserDeleteParams{}
 	if err := retrieveRequestParams(r, params); err != nil {
-		if err.(*HTTPError).ErrorCode == ErrorCodeBadJSON {
+		if err.(*HTTPError).ErrorCode == ErrorCodeEmptyRequestBody {
 			// request body is empty so the default behavior should be to hard delete the user
 			params.ShouldSoftDelete = false
 		} else {

internal/api/errorcodes.go

@@ -11,6 +11,7 @@ const (
 
 	ErrorCodeValidationFailed                  ErrorCode = "validation_failed"
 	ErrorCodeBadJSON                           ErrorCode = "bad_json"
+	ErrorCodeEmptyRequestBody                  ErrorCode = "empty_request_body"
 	ErrorCodeEmailExists                       ErrorCode = "email_exists"
 	ErrorCodePhoneExists                       ErrorCode = "phone_exists"
 	ErrorCodeBadJWT                            ErrorCode = "bad_jwt"

internal/api/helpers.go

@@ -96,6 +96,9 @@ func retrieveRequestParams[A RequestParams](r *http.Request, params *A) error {
 	if err != nil {
 		return internalServerError("Could not read body into byte slice").WithInternalError(err)
 	}
+	if len(body) == 0 {
+		return badRequestError(ErrorCodeEmptyRequestBody, "Request body is empty and not a valid JSON")
+	}
 	if err := json.Unmarshal(body, params); err != nil {
 		return badRequestError(ErrorCodeBadJSON, "Could not parse request body as JSON: %v", err)
 	}