-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add inactivity-timeout to sessions #1288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
commented
Oct 30, 2023
hf
force-pushed
the
hf/inactivity-timeout-sessions
branch
2 times, most recently
from
November 1, 2023 10:26
72ca691
to
60beb19
Compare
J0
approved these changes
Nov 2, 2023
J0
reviewed
Nov 2, 2023
kangmingtay
approved these changes
Nov 3, 2023
kangmingtay
reviewed
Nov 3, 2023
hf
force-pushed
the
hf/inactivity-timeout-sessions
branch
from
November 4, 2023 11:59
60beb19
to
786d0c9
Compare
This was referenced Nov 4, 2023
hf
force-pushed
the
hf/inactivity-timeout-sessions
branch
from
November 6, 2023 14:47
786d0c9
to
e7f1767
Compare
Added one change I did not foresee and that is, if the session has no |
hf
force-pushed
the
hf/inactivity-timeout-sessions
branch
from
November 6, 2023 20:11
e7f1767
to
79330c2
Compare
hf
force-pushed
the
hf/inactivity-timeout-sessions
branch
from
November 6, 2023 20:11
79330c2
to
98086f6
Compare
kangmingtay
reviewed
Nov 6, 2023
🎉 This PR is included in version 2.108.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hf
added a commit
that referenced
this pull request
Nov 7, 2023
Builds on top of #1288. Adds cleanup for timeboxed sessions and sessions that have expired due to inactivity timeout. It achieves backward compatibility with sessions that have `null` in `refreshed_at` by looking at the `updated_at` column of the refresh tokens table. This approach is the one that puts the least strain on the database, having considered backfilling (very expensive at least `O(nlogn)` over the whole refresh tokens table).
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
Adds the ability for sessions to time-out after a period of inactivity. "Activity" is defined as refreshing the session. This can be configured by setting the `GOTRUE_SESSIONS_INACTIVITY_TIMEOUT` to a duration. Since this PR modifies the database by adding a new `refreshed_at` nullable column to `sessions`, it also adds some useful columns to the `sessions` table to track the `User-Agent` and IP address that performed the refresh / session creation.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
…e#1298) Builds on top of supabase#1288. Adds cleanup for timeboxed sessions and sessions that have expired due to inactivity timeout. It achieves backward compatibility with sessions that have `null` in `refreshed_at` by looking at the `updated_at` column of the refresh tokens table. This approach is the one that puts the least strain on the database, having considered backfilling (very expensive at least `O(nlogn)` over the whole refresh tokens table).
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
Adds the ability for sessions to time-out after a period of inactivity. "Activity" is defined as refreshing the session. This can be configured by setting the `GOTRUE_SESSIONS_INACTIVITY_TIMEOUT` to a duration. Since this PR modifies the database by adding a new `refreshed_at` nullable column to `sessions`, it also adds some useful columns to the `sessions` table to track the `User-Agent` and IP address that performed the refresh / session creation.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
…e#1298) Builds on top of supabase#1288. Adds cleanup for timeboxed sessions and sessions that have expired due to inactivity timeout. It achieves backward compatibility with sessions that have `null` in `refreshed_at` by looking at the `updated_at` column of the refresh tokens table. This approach is the one that puts the least strain on the database, having considered backfilling (very expensive at least `O(nlogn)` over the whole refresh tokens table).
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
Adds the ability for sessions to time-out after a period of inactivity. "Activity" is defined as refreshing the session. This can be configured by setting the `GOTRUE_SESSIONS_INACTIVITY_TIMEOUT` to a duration. Since this PR modifies the database by adding a new `refreshed_at` nullable column to `sessions`, it also adds some useful columns to the `sessions` table to track the `User-Agent` and IP address that performed the refresh / session creation.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
…e#1298) Builds on top of supabase#1288. Adds cleanup for timeboxed sessions and sessions that have expired due to inactivity timeout. It achieves backward compatibility with sessions that have `null` in `refreshed_at` by looking at the `updated_at` column of the refresh tokens table. This approach is the one that puts the least strain on the database, having considered backfilling (very expensive at least `O(nlogn)` over the whole refresh tokens table).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for sessions to time-out after a period of inactivity. "Activity" is defined as refreshing the session.
This can be configured by setting the
GOTRUE_SESSIONS_INACTIVITY_TIMEOUT
to a duration.Since this PR modifies the database by adding a new
refreshed_at
nullable column tosessions
, it also adds some useful columns to thesessions
table to track theUser-Agent
and IP address that performed the refresh / session creation.