fix: potential panics on error #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
commented
Jan 29, 2024
J0
approved these changes
Jan 29, 2024
hf
approved these changes
Jan 29, 2024
|
🎉 This PR is included in version 2.139.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * In the [`net/http` Do method](https://pkg.go.dev/net/http#Client.Do), if an error is returned, the http response should be ignored. Currently, we defer closing the response body which leads to a nil pointer error
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * In the [`net/http` Do method](https://pkg.go.dev/net/http#Client.Do), if an error is returned, the http response should be ignored. Currently, we defer closing the response body which leads to a nil pointer error
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
## What kind of change does this PR introduce? * In the [`net/http` Do method](https://pkg.go.dev/net/http#Client.Do), if an error is returned, the http response should be ignored. Currently, we defer closing the response body which leads to a nil pointer error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
net/httpDo method, if an error is returned, the http response should be ignored. Currently, we defer closing the response body which leads to a nil pointer error