Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ci: upload release artifact to supabase s3 bucket" #1854

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Revert "ci: upload release artifact to supabase s3 bucket" #1854

merged 1 commit into from
Dec 3, 2024

Conversation

kangmingtay
Copy link
Member

Reverts #1812

@kangmingtay kangmingtay requested a review from a team as a code owner December 3, 2024 04:11
@kangmingtay kangmingtay force-pushed the revert-1812-hf/artifact-bucket branch from 5fca11d to 2c11a04 Compare December 3, 2024 04:13
@coveralls
Copy link

coveralls commented Dec 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12132825292

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.998%
Totals Coverage Status
Change from base Build 12072019547: 0.0%
Covered Lines: 9546
Relevant Lines: 16748
💛 - Coveralls

J0
J0 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a prefix for semver in title: (e.g. fix: Revert "ci: upload release artifact to supabase s3 bucket" #1854)

Should be fine w/o as well though since there are no code changes.

@kangmingtay kangmingtay merged commit 1bad34e into master Dec 3, 2024
2 checks passed
@kangmingtay kangmingtay deleted the revert-1812-hf/artifact-bucket branch December 3, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0 J0 J0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kangmingtay @coveralls @J0