Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setting the mailer service headers as strings (#1861) #1862

Closed
wants to merge 1 commit into from

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Request made to email validation service should be a POST
  • Update error message when config validation fails

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

## What kind of change does this PR introduce?
* Request made to email validation service should be a `POST`
* Update error message when config validation fails
@kangmingtay kangmingtay requested a review from a team as a code owner December 6, 2024 09:31
@kangmingtay kangmingtay closed this Dec 6, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12196367696

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 57.264%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/conf/configuration.go 0 1 0.0%
internal/mailer/validate.go 2 3 66.67%
Totals Coverage Status
Change from base Build 12192682911: -0.004%
Covered Lines: 9696
Relevant Lines: 16932

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants