Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move orioledb to extensions schema by default #1433

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

olirice
Copy link
Contributor

@olirice olirice commented Feb 5, 2025

Moves the orioledb extension to the extensions schema if:

  • orioledb is enabled in the public schema
  • the extensions schema exists

This is important because orioledb exposes some entities that we don't necessarily want exposed over APIs by default

@olirice olirice requested a review from a team as a code owner February 5, 2025 15:06
@olirice olirice requested a review from soedirgo February 5, 2025 15:07
@olirice olirice requested a review from samrose February 10, 2025 15:03
@samrose
Copy link
Contributor

samrose commented Feb 14, 2025

@olirice anything I can do to help move this one forward?

@olirice
Copy link
Contributor Author

olirice commented Feb 14, 2025

to the best of my knowledge this is ready to merge. but pending review from backend
i haven't added many migrations so would be good to get a real review in case there are any flows im not aware of

@samrose
Copy link
Contributor

samrose commented Feb 14, 2025

@olirice I am going to try to and test this out later today based on your branch.

If you have specific scenarios beyond the success of migration, pause/restore, extension compat that would be important to test please let me know

@samrose
Copy link
Contributor

samrose commented Feb 18, 2025

@olirice recommending that we use this, which mirrors your changes but based off of the latest develop branch

#1448

Just need to sort out the testinfra issue on that, and should be good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants