fix: remove auth stats collection from postgres_exporter #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR is to remove auth stats collection from postgres_exporter, which caused performance issue on user's db with a large
auth.audit_log_entriestable. Below 2 metrics will be removed after this PR:total_auth_emails
total_auth_texts
Context: https://supabase.slack.com/archives/C022071RB2L/p1709132413873409
HubSpot ticket: https://app.hubspot.com/live-messages/19953346/inbox/6610456592#comment
What is the current behavior?
This regular stats collection query caused high cpu spikes on user's db, which has a large
auth.audit_log_entriestable.What is the new behavior?
Removed that stats collection query should remove high cpu spikes it casued.
Additional context
Also raised same PR on infra repo: https://github.com/supabase/infrastructure/pull/17391