chore: remove pgbouncer from AIO image except pg role [GEN-8039] #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcnc
approved these changes
May 13, 2024
| @@ -52,5 +50,4 @@ sed -i "s|{{ .ApiKey }}|$LOGFLARE_API_KEY|g" $VECTOR_CONF | |||
| sed -i "s|{{ .DbSource }}|$LOGFLARE_DB_SOURCE|g" $VECTOR_CONF | |||
| sed -i "s|{{ .GotrueSource }}|$LOGFLARE_GOTRUE_SOURCE|g" $VECTOR_CONF | |||
| sed -i "s|{{ .PostgrestSource }}|$LOGFLARE_POSTGREST_SOURCE|g" $VECTOR_CONF | |||
| sed -i "s|{{ .PgbouncerSource }}|$LOGFLARE_PGBOUNCER_SOURCE|g" $VECTOR_CONF | |||
| sed -i "s|{{ .PitrErrorsSource }}|$LOGFLARE_PITR_ERRORS_SOURCE|g" $VECTOR_CONF | |||
| sed -i "s|{{ .PitrErrorsSource }}|$LOGFLARE_PITR_ERRORS_SOURCE|g" $VECTOR_CONF | |||
There was a problem hiding this comment.
😱 need to update my formatters to do it automatically 🤖
pcnc
reviewed
May 13, 2024
| \set auth_pass `echo "${SUPABASE_AUTH_ADMIN_PASSWORD:-$POSTGRES_PASSWORD}"` | ||
| \set storage_pass `echo "${SUPABASE_STORAGE_ADMIN_PASSWORD:-$POSTGRES_PASSWORD}"` | ||
| \set replication_pass `echo "${SUPABASE_REPLICATION_ADMIN_PASSWORD:-$POSTGRES_PASSWORD}"` | ||
| \set read_only_pass `echo "${SUPABASE_READ_ONLY_USER_PASSWORD:-$POSTGRES_PASSWORD}"` | ||
|
|
||
| ALTER USER supabase_admin WITH PASSWORD :'admin_pass'; | ||
| ALTER USER authenticator WITH PASSWORD :'pgrst_pass'; | ||
| ALTER USER pgbouncer WITH PASSWORD :'pgbouncer_pass'; |
There was a problem hiding this comment.
This would need to be kept around as supavisor is still using the user
pcnc
reviewed
May 13, 2024
There was a problem hiding this comment.
There might still be processes which are using this :saddog: namely config updates. We should gut them out of the worker first
pcnc
reviewed
May 14, 2024
| @@ -2,7 +2,6 @@ Cmnd_Alias ENVOY = /usr/bin/supervisorctl start services\:envoy, /usr/bin/superv | |||
| Cmnd_Alias KONG = /usr/bin/supervisorctl start services\:kong, /usr/bin/supervisorctl stop services\:kong, /usr/bin/supervisorctl restart services\:kong, /usr/bin/supervisorctl status services\:kong | |||
| Cmnd_Alias POSTGREST = /usr/bin/supervisorctl start services\:postgrest, /usr/bin/supervisorctl stop services\:postgrest, /usr/bin/supervisorctl restart services\:postgrest, /usr/bin/supervisorctl status services\:postgrest | |||
| Cmnd_Alias GOTRUE = /usr/bin/supervisorctl start services\:gotrue, /usr/bin/supervisorctl stop services\:gotrue, /usr/bin/supervisorctl restart services\:gotrue, /usr/bin/supervisorctl status services\:gotrue | |||
| Cmnd_Alias PGBOUNCER = /usr/bin/supervisorctl start pgbouncer, /usr/bin/supervisorctl stop pgbouncer, /usr/bin/supervisorctl restart pgbouncer, /usr/bin/supervisorctl status pgbouncer | |||
There was a problem hiding this comment.
Wound still need this to allow perms for adminapi to run lifecycle commands (restarts, reloads etc)
|
closing as stale. please re-open as needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same changes as previous PR #907 , except this will keep the .sql that creates the pgbouncer role. This will be kept for now until the full pgbouncer cleanup happens, since there were migrations failing due to the lack of pgbouncer role present, when creating new projects in Fly, during tests in Staging.
Before opening the PR, this changes were tested with
aio-15.1.1.31-no-pgbouncer-dockerimage in staging, which went through, creating a complete project with no issues and no pgbouncer presence, except for the role, as mentioned before.