#523 fix typescript error for aggregate functions

[stefan-girlich]

What kind of change does this PR introduce?

Fix dynamic TypeScript type for data when using aggregate functions other than count

What is the current behavior?

Aggregate functions other than count will result in TypeScript errors for the resulting type of data (#523)

Bug fix for issues:

• ParserError "Unexpected input: .sum()" when using aggregate functions with TypeScript #523
• [supabase-js] Parser error for using aggregate and spread #524 (potentially, not tested explicitly)

What is the new behavior?

Using the other aggregate functions "sum", "avg", "min", and "max" will not result in an erroneous TypeScript type for data.

Additional context

I just generalized changes from #520 by @bnjmnt4n ; thanks for your work!

[bnjmnt4n]

Do the queries work when just querying Postgrest? My understanding when implementing this, based on https://postgrest.org/en/v12/references/api/aggregate_functions.html, was that the syntax was column.max(), and not column(max).

[stefan-girlich]

@bnjmnt4n You're right; column(max) is not valid; my fix is therefore not ideal as it allows for invalid syntax.
Would you have any idea concerning how to fix the issues with the other aggregation functions besides count() (#523 , #524 )?

[bnjmnt4n]

Do you have a reproducible failing test case or example?

[stefan-girlich]

Sure; I mentioned them in #523 for visibility: #523 (comment)

[avallete]

A global fix has now been released in supabase-js v2.46.0, covering this issue. Thank you for your effort and work on this PR—it’s much appreciated! I’ll be closing this PR, but please feel free to reach out if there are any further issues.