feat: use iodata for metrics export #586
Merged
+197
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
force-pushed
the
use-iodata-for-metrics
branch
from
0062e1c to
cb49404
Compare
abc3
approved these changes
Jan 30, 2025
hauleth
force-pushed
the
use-iodata-for-metrics
branch
4 times, most recently
from
2e5f303 to
f46fe8f
Compare
This prevents memory bloat form creating all intermediate binaries that are later dropped. Instead we try to reuse as much of binaries as possible and then let the VM do the concatenation if needed.
hauleth
force-pushed
the
use-iodata-for-metrics
branch
from
f46fe8f to
6f2e8c1
Compare
filipecabaco
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents memory bloat form creating all intermediate binaries that are later dropped. Instead we try to reuse as much of binaries as possible and then let the VM do the concatenation if needed.