-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix failing e2e #2185
Merged
Merged
fix failing e2e #2185
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
408d194
fix failing e2e
petrjasek dbb1230
lock client core version for e2e
petrjasek 3117d9c
revert changes
petrjasek 669a93c
fix dates
petrjasek 3f20b4d
fix contacts test
petrjasek b1ee1ea
revert time changes
petrjasek 29c3bcc
reset utils changes
petrjasek 6228d18
remove extra code
petrjasek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
import React from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import {gettext} from 'core/utils'; | ||
|
||
export const ActionBar: React.FunctionComponent<any> = ({svc, readOnly, dirty, valid, onSave, onCancel}) => ( | ||
<div className="action-bar show"> | ||
<div className="button-group button-group--end button-group--comfort"> | ||
<button | ||
id="cancel-edit-btn" | ||
type="button" | ||
className="btn" | ||
onClick={onCancel} | ||
> | ||
{gettext('Cancel')} | ||
</button> | ||
|
||
{!readOnly && ( | ||
<button | ||
id="save-edit-btn" | ||
type="button" | ||
className="btn btn--primary" | ||
onClick={onSave} | ||
disabled={!valid || !dirty} | ||
> | ||
{gettext('Save')} | ||
</button> | ||
)} | ||
</div> | ||
</div> | ||
); | ||
|
||
ActionBar.propTypes = { | ||
svc: PropTypes.object.isRequired, | ||
onSave: PropTypes.func, | ||
onCancel: PropTypes.func, | ||
readOnly: PropTypes.bool, | ||
dirty: PropTypes.bool, | ||
valid: PropTypes.bool, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fritzSF @tomaskikutis Are there components in the UI Framework that can be used here instead of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is subnav that might be similar, but if existing one works without issues I won't be spending time to replace it.