Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STTNHUB-292] fix: Use empty slugline for Placeholder Coverages #43

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

MarkLark86
Copy link
Contributor

No description provided.

@MarkLark86 MarkLark86 requested a review from petrjasek November 24, 2023 04:29
@devketanpro
Copy link
Member

hi, @MarkLark86 , I wonder: if we remove the slugline from these placeholder coverages, how can the user identify whether this is a placeholder coverage or not?

@MarkLark86
Copy link
Contributor Author

MarkLark86 commented Nov 24, 2023

hi, @MarkLark86 , I wonder: if we remove the slugline from these placeholder coverages, how can the user identify whether this is a placeholder coverage or not?

From a logical point of view (from code) we have the placeholder flag.

The customer doesn't want this slugline shown in Newshub (especially considering it's in English).

And, at this point in time, the customer doesn't use Superdesk directly. It's more of a headless CMS for them

Copy link
Member

@devketanpro devketanpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense; thanks for clarifying.

@petrjasek petrjasek added this to the sttnh2.5 milestone Nov 24, 2023
@MarkLark86 MarkLark86 merged commit d8f598a into superdesk:uat Nov 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants