Skip to content

Commit

Permalink
Updates for #1538 (#1717)
Browse files Browse the repository at this point in the history
  • Loading branch information
angelosilvestre authored and matthew-carroll committed Dec 28, 2023
1 parent be0e784 commit 0147723
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ class _EditorToolbarState extends State<EditorToolbar> {
id: alignment.name,
icon: _buildTextAlignIcon(alignment),
),
items: TextAlign.values
items: const [TextAlign.left, TextAlign.center, TextAlign.right, TextAlign.justify]
.map(
(alignment) => SuperEditorDemoIconItem(
icon: _buildTextAlignIcon(alignment),
Expand Down
7 changes: 4 additions & 3 deletions super_editor/test/infrastructure/popover_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,8 @@ void main() {
expect(popoverRect.bottom, lessThan(buttonRect.top));
});

testWidgetsOnAllPlatforms('pins the popover to the bottom if there is not room below or above the button',
testWidgetsOnAllPlatforms(
'pins the popover to the bottom of boundary if there is not room below or above the button',
(tester) async {
final boundaryKey = GlobalKey();
final buttonKey = GlobalKey();
Expand Down Expand Up @@ -416,8 +417,8 @@ void main() {
expect(popoverRect.bottom, lessThan(buttonRect.top));
});

testWidgetsOnAllPlatforms('pins the popover to the bottom if there is not room below or above the button',
(tester) async {
testWidgetsOnAllPlatforms(
'pins the popover to the bottom of screen if there is not room below or above the button', (tester) async {
final buttonKey = GlobalKey();
final popoverController = PopoverController();

Expand Down

0 comments on commit 0147723

Please sign in to comment.