Add pixel tolerance

superlistapp · Dec 31, 2024 · 1de969a · 1de969a
1 parent add74b1
commit 1de969a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/super_editor/test_goldens/editor/mobile/supereditor_android_overlay_controls_test.dart b/super_editor/test_goldens/editor/mobile/supereditor_android_overlay_controls_test.dart
@@ -1,6 +1,5 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
-import 'package:golden_toolkit/golden_toolkit.dart';
 import 'package:super_editor/super_editor.dart';
 import 'package:super_editor/super_editor_test.dart';
 
@@ -36,7 +35,11 @@ void main() {
         await tester.pump();
       }
 
-      await screenMatchesGolden(tester, 'supereditor_android_magnifier_screen_edges');
+      await tester.pump();
+      await expectLater(
+        find.byType(MaterialApp),
+        matchesGoldenFileWithPixelAllowance("goldens/supereditor_android_magnifier_screen_edges.png", 52),
+      );
 
       // Release the gesture.
       await gesture.up();

diff --git a/super_editor/test_goldens/super_textfield/super_textfield_android_overlay_controls_test.dart b/super_editor/test_goldens/super_textfield/super_textfield_android_overlay_controls_test.dart
@@ -1,7 +1,6 @@
 import 'package:attributed_text/attributed_text.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
-import 'package:golden_toolkit/golden_toolkit.dart';
 import 'package:super_editor/super_text_field.dart';
 
 import '../../test/super_textfield/super_textfield_robot.dart';
@@ -50,7 +49,10 @@ void main() {
       final gesture = await tester.dragCaretByDistanceInSuperTextField(const Offset(-200, 0));
       await tester.pump();
 
-      await screenMatchesGolden(tester, 'super_textfield_android_magnifier_screen_edges');
+      await expectLater(
+        find.byType(MaterialApp),
+        matchesGoldenFileWithPixelAllowance("goldens/super_textfield_android_magnifier_screen_edges.png", 38),
+      );
 
       // Release the gesture.
       await gesture.up();

diff --git a/super_editor/test_goldens/super_textfield/super_textfield_ios_overlay_controls_test.dart b/super_editor/test_goldens/super_textfield/super_textfield_ios_overlay_controls_test.dart
@@ -1,6 +1,5 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
-import 'package:golden_toolkit/golden_toolkit.dart';
 import 'package:super_editor/super_editor.dart';
 
 import '../../test/super_textfield/super_textfield_robot.dart';
@@ -49,7 +48,10 @@ void main() {
       final gesture = await tester.dragCaretByDistanceInSuperTextField(const Offset(-200, 0));
       await tester.pump();
 
-      await screenMatchesGolden(tester, 'super_textfield_ios_magnifier_screen_edges');
+      await expectLater(
+        find.byType(MaterialApp),
+        matchesGoldenFileWithPixelAllowance("goldens/super_textfield_ios_magnifier_screen_edges.png", 4),
+      );
 
       // Release the gesture.
       await gesture.up();