Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick "Updates for #1538 (#1717)" to stable #1719

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Cherry-pick "Updates for #1538 (#1717)" to stable #1719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion super_editor/example/lib/demos/example_editor/_toolbar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ class _EditorToolbarState extends State<EditorToolbar> {
id: alignment.name,
icon: _buildTextAlignIcon(alignment),
),
items: TextAlign.values
items: const [TextAlign.left, TextAlign.center, TextAlign.right, TextAlign.justify]
.map(
(alignment) => SuperEditorDemoIconItem(
icon: _buildTextAlignIcon(alignment),
Expand Down
7 changes: 4 additions & 3 deletions super_editor/test/infrastructure/popover_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,8 @@ void main() {
expect(popoverRect.bottom, lessThan(buttonRect.top));
});

testWidgetsOnAllPlatforms('pins the popover to the bottom if there is not room below or above the button',
testWidgetsOnAllPlatforms(
'pins the popover to the bottom of boundary if there is not room below or above the button',
(tester) async {
final boundaryKey = GlobalKey();
final buttonKey = GlobalKey();
Expand Down Expand Up @@ -416,8 +417,8 @@ void main() {
expect(popoverRect.bottom, lessThan(buttonRect.top));
});

testWidgetsOnAllPlatforms('pins the popover to the bottom if there is not room below or above the button',
(tester) async {
testWidgetsOnAllPlatforms(
'pins the popover to the bottom of screen if there is not room below or above the button', (tester) async {
final buttonKey = GlobalKey();
final popoverController = PopoverController();

Expand Down