[SuperEditor] Make getDocumentPositionAfterExpandedDeletion return null for collapsed selections (Resolves #2431) #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll for collapsed selections (Resolves #2431)
matthew-carroll
deleted the
2431_getDocumentPositionAfterExpandedDeletion-return-null
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor] Make getDocumentPositionAfterExpandedDeletion return null for collapsed selections. Resolves #2431
The
CommonEditorOperations.getDocumentPositionAfterExpandedDeletionreturns aTextNodePositioneven when the selection is collapsed. In this situation, we expect nothing to be deleted and no selection change.Currently, if all nodes in the selection are non-deletable, this method returns
null. To keep consistency, this PR changes this method to also returnnullwhen the selection is collapsed.f