Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export src/infrastructure/platforms/platform.dart #2514

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

miguelcmedeiros
Copy link
Collaborator

Exports src/infrastructure/platforms/platform.dart that it's possible to access debugIsWebOverride in tests.

@matthew-carroll
Copy link
Contributor

If you need this for tests, and if that's the only reasonable public use-case, can you export from the test lib, instead of the main lib?

@miguelcmedeiros
Copy link
Collaborator Author

If you need this for tests, and if that's the only reasonable public use-case, can you export from the test lib, instead of the main lib?

@matthew-carroll

Copy link
Contributor

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit 3265ac2 into main Jan 20, 2025
16 checks passed
@matthew-carroll matthew-carroll deleted the export-platform-dart branch January 20, 2025 19:27
@matthew-carroll
Copy link
Contributor

@angelosilvestre can you cherry pick this whenever you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants