revert: bumperAssetId shortcode

superstreamerapp · Sep 12, 2024 · e625f7e · e625f7e
1 parent 3d5153d
commit e625f7e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 15 deletions.
diff --git a/packages/stitcher/src/contract.ts b/packages/stitcher/src/contract.ts
@@ -5,7 +5,11 @@ import base64 from "hi-base64";
 const c = initContract();
 
 const sessionParams = z.object({
-  vmapUrl: z.string().optional(),
+  vmap: z
+    .object({
+      url: z.string(),
+    })
+    .optional(),
   interstitials: z
     .array(
       z.object({
@@ -15,7 +19,6 @@ const sessionParams = z.object({
       }),
     )
     .optional(),
-  bumperAssetId: z.string().optional(),
   maxResolution: z.coerce.number().optional(),
 });
 

diff --git a/packages/stitcher/src/session.ts b/packages/stitcher/src/session.ts
@@ -26,9 +26,10 @@ const PlaylistUnavailableError = createError<[string]>(
 
 export async function createSession(data: {
   assetId: string;
-  vmapUrl?: string;
+  vmap?: {
+    url: string;
+  };
   interstitials?: Interstitial[];
-  bumperAssetId?: string;
   maxResolution?: number;
 }) {
   if (!(await isAssetAvailable(data.assetId))) {
@@ -39,8 +40,8 @@ export async function createSession(data: {
 
   const interstitials: Interstitial[] = [];
 
-  if (data.vmapUrl) {
-    const vmap = await getVmap(data.vmapUrl);
+  if (data.vmap) {
+    const vmap = await getVmap(data.vmap.url);
 
     for (const adBreak of vmap.adBreaks) {
       interstitials.push(
@@ -53,15 +54,6 @@ export async function createSession(data: {
     interstitials.push(...data.interstitials);
   }
 
-  // When we have a bumper, we'll push it at the end of the interstitials list.
-  if (data.bumperAssetId) {
-    interstitials.push({
-      timeOffset: 0,
-      assetId: data.bumperAssetId,
-      type: "bumper",
-    });
-  }
-
   let maxResolution = data.maxResolution;
   if (!maxResolution) {
     const MAX_RESOLUTION_8K = 4320;