Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got an
Input
and aStream
type. An ffmpeg job is scheduled with a full input and stream.What we can do is run an ffprobe child job first, and once that's finished we can schedule each ffmpeg job separately.
This way we use the ffprobe result to fill in defaults directly from the input source, without forcing the user to know everything upfront. I can imagine people don't know the channel count for every individual asset that's about to be transcoded.
There's a few mandatory values (such as a text track MUST specify a language, or we won't be able to match it) but we can let the API handle sanity checks and stop early when a value is not provided for a required field.
Top of my head but we can probably probe for the following fields: