Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#157] bytestrings used consistently, plus docs and tests #158

Merged
merged 11 commits into from
Jul 16, 2024

Conversation

susanw1
Copy link
Owner

@susanw1 susanw1 commented Jul 16, 2024

No description provided.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.77470% with 79 lines in your changes missing coverage. Please review.

Project coverage is 49.43%. Comparing base (8b6eca6) to head (6ea6a96).

Files Patch % Lines
...net/zscript/javaclient/nodes/ZscriptBasicNode.java 0.00% 12 Missing ⚠️
...javaclient/commandPaths/ResponseExecutionPath.java 0.00% 10 Missing ⚠️
...client/commandPrinting/StandardCommandGrapher.java 9.09% 10 Missing ⚠️
...cript/javaclient/commandPaths/ZscriptFieldSet.java 46.66% 8 Missing ⚠️
.../net/zscript/javaclient/commandPaths/BigField.java 70.83% 7 Missing ⚠️
.../net/zscript/javaclient/commandPaths/Response.java 0.00% 7 Missing ⚠️
.../zscript/javaclient/sequence/ResponseSequence.java 0.00% 7 Missing ⚠️
...script/javaclient/addressing/AddressedCommand.java 0.00% 3 Missing ⚠️
...t/zscript/javaclient/sequence/CommandSequence.java 0.00% 3 Missing ⚠️
...et/zscript/javaclient/sequence/ZscriptLockSet.java 0.00% 3 Missing ⚠️
... and 7 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
+ Coverage     46.97%   49.43%   +2.46%     
- Complexity      711      788      +77     
============================================
  Files           130      131       +1     
  Lines          5001     4978      -23     
  Branches        825      820       -5     
============================================
+ Hits           2349     2461     +112     
+ Misses         2444     2311     -133     
+ Partials        208      206       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susanw1 susanw1 merged commit 30b224f into master Jul 16, 2024
2 checks passed
@susanw1 susanw1 deleted the 157-bytestrings-consistently-docs-and-tests branch July 16, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants