Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#145] Restore cucumber acceptance tests #177

Merged
merged 28 commits into from
Jan 10, 2025

Conversation

susanw1
Copy link
Owner

@susanw1 susanw1 commented Dec 31, 2024

No description provided.

@susanw1 susanw1 self-assigned this Dec 31, 2024
@susanw1 susanw1 linked an issue Dec 31, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 47.20670% with 189 lines in your changes missing coverage. Please review.

Project coverage is 55.23%. Comparing base (3273dcb) to head (b47ff42).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...net/zscript/javaclient/nodes/DirectConnection.java 0.00% 80 Missing ⚠️
...in/java/net/zscript/javaclient/devices/Device.java 0.00% 19 Missing ⚠️
...et/zscript/javaclient/testing/LocalConnection.java 0.00% 16 Missing ⚠️
.../javaclient/commandPaths/CommandExecutionPath.java 52.94% 8 Missing ⚠️
...cript/javaclient/connectors/tcp/TcpConnection.java 0.00% 7 Missing ⚠️
...net/zscript/javaclient/nodes/ZscriptBasicNode.java 0.00% 6 Missing ⚠️
...javaclient/commandPaths/ResponseExecutionPath.java 61.53% 2 Missing and 3 partials ⚠️
...cript/javaclient/commandPaths/ZscriptFieldSet.java 90.74% 2 Missing and 3 partials ⚠️
...net/zscript/javaclient/nodes/AddressingSystem.java 0.00% 5 Missing ⚠️
.../net/zscript/tokenizer/ZscriptTokenExpression.java 20.00% 4 Missing ⚠️
... and 21 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #177      +/-   ##
============================================
+ Coverage     51.72%   55.23%   +3.50%     
- Complexity      880     1001     +121     
============================================
  Files           134      136       +2     
  Lines          5073     5247     +174     
  Branches        823      846      +23     
============================================
+ Hits           2624     2898     +274     
+ Misses         2242     2120     -122     
- Partials        207      229      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susanw1 susanw1 force-pushed the 145-restore-cucumber-acceptance-tests branch from 2ff1a56 to b47ff42 Compare January 10, 2025 16:08
@susanw1 susanw1 merged commit 1786a18 into master Jan 10, 2025
2 of 4 checks passed
@susanw1 susanw1 deleted the 145-restore-cucumber-acceptance-tests branch January 10, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore Cucumber acceptance tests
1 participant