Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please ignore - checkstyle testing #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

suside
Copy link
Owner

@suside suside commented Feb 5, 2022

No description provided.

@@ -51,6 +51,7 @@ public long getItemId(int pos) {
@Override
public View getView(final int position, final View convertView, ViewGroup parent) {
View view = convertView;
View view2_bad_format_test = convertView;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 12, expected level should be 4.

Copy link
Owner Author

@suside suside Feb 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this run is with filter_mode: added

@@ -51,6 +51,7 @@ public long getItemId(int pos) {
@Override
public View getView(final int position, final View convertView, ViewGroup parent) {
View view = convertView;
View view2_bad_format_test = convertView;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.LocalVariableNameCheck> reported by reviewdog 🐶
Local variable name 'view2_bad_format_test' must match pattern '^a-z?$'.

@@ -67,6 +68,7 @@ public void onClick(View v) {
Callback<ResponseBody> deleteFollowerListener = new Callback<ResponseBody>() {
@Override
public void onResponse(Response<ResponseBody> response, Retrofit retrofit) {
Retrofit tetrofit2_bad_format_test = retrofit;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.LocalVariableNameCheck> reported by reviewdog 🐶
Local variable name 'tetrofit2_bad_format_test' must match pattern '^a-z?$'.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with filter_mode: added checkstyle was unable to detect missing indention

@@ -51,6 +51,7 @@ public long getItemId(int pos) {
@Override
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.

Copy link
Owner Author

@suside suside Feb 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this run is with filter_mode: diff_context

@@ -51,6 +51,7 @@ public long getItemId(int pos) {
@Override
public View getView(final int position, final View convertView, ViewGroup parent) {
View view = convertView;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.

@@ -51,6 +51,7 @@ public long getItemId(int pos) {
@Override
public View getView(final int position, final View convertView, ViewGroup parent) {
View view = convertView;
View view2_bad_format_test = convertView;
if (view == null) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 8, expected level should be 4.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the 'if' has correct indentation but not the line before. Strange.

@@ -51,6 +51,7 @@ public long getItemId(int pos) {
@Override
public View getView(final int position, final View convertView, ViewGroup parent) {
View view = convertView;
View view2_bad_format_test = convertView;
if (view == null) {
LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 113).

@@ -51,6 +51,7 @@ public long getItemId(int pos) {
@Override
public View getView(final int position, final View convertView, ViewGroup parent) {
View view = convertView;
View view2_bad_format_test = convertView;
if (view == null) {
LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 12, expected level should be 6.

@@ -51,6 +51,7 @@ public long getItemId(int pos) {
@Override
public View getView(final int position, final View convertView, ViewGroup parent) {
View view = convertView;
View view2_bad_format_test = convertView;
if (view == null) {
LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
view = inflater.inflate(R.layout.item_follower, null);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 12, expected level should be 6.

@@ -67,6 +68,7 @@ public void onClick(View v) {
Callback<ResponseBody> deleteFollowerListener = new Callback<ResponseBody>() {
@Override
public void onResponse(Response<ResponseBody> response, Retrofit retrofit) {
Retrofit tetrofit2_bad_format_test = retrofit;
if (response.isSuccess()) {
Toast.makeText(context, gs(R.string.follower_deleted_succesfully), Toast.LENGTH_LONG).show();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 121).

@@ -67,6 +68,7 @@ public void onClick(View v) {
Callback<ResponseBody> deleteFollowerListener = new Callback<ResponseBody>() {
@Override
public void onResponse(Response<ResponseBody> response, Retrofit retrofit) {
Retrofit tetrofit2_bad_format_test = retrofit;
if (response.isSuccess()) {
Toast.makeText(context, gs(R.string.follower_deleted_succesfully), Toast.LENGTH_LONG).show();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 28, expected level should be one of the following: 22, 24, 26.

@@ -67,6 +68,7 @@ public void onClick(View v) {
Callback<ResponseBody> deleteFollowerListener = new Callback<ResponseBody>() {
@Override
public void onResponse(Response<ResponseBody> response, Retrofit retrofit) {
Retrofit tetrofit2_bad_format_test = retrofit;
if (response.isSuccess()) {
Toast.makeText(context, gs(R.string.follower_deleted_succesfully), Toast.LENGTH_LONG).show();
list.remove(position);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 28, expected level should be one of the following: 22, 24, 26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants