Automatic download and build of MOAB #969

bam241 · 2024-12-04T20:25:45Z

Description

Add capability to automate pull and build MOAB at DAGMC building time

This is redondant with #964

Motivation and Context

This is part of the project from @shimwell on getting a pip install for OpenMC with DAGMC.

Changes

tweaked a little bit the findMOAB.cmake

add a make files that contains the proper ExternalProject configuration
add a CMAKE variable to enable pull and build and change the dips and link for the other DAGMC library

Behavior

Nothing changes if DDL_DEPS is not set at ON on Cmake configuration.
Otherwise pull build MOAB from MOAB repo builds it, and build the DAGMC lib against it.

Changelog file

Done

This is very much inspired by @ahnaf-tahmid-chowdhury work on PyNE cmake.

This works is sponsored by Proxima Fusion

bam241 · 2024-12-04T20:29:51Z

@ahnaf-tahmid-chowdhury @shimwell @gonuke even if this is still a draft, feel free to provide any feed back!

src/pyne/CMakeLists.txt

src/dagmc/CMakeLists.txt

bam241 · 2024-12-04T20:32:36Z

cmake/FindMOAB.cmake

+else()
+  # message(FATAL_ERROR "Could not find MOAB")


This should still return a fatal_error if ExternalProject encounters an issue

bam241 · 2024-12-04T20:34:14Z

The safeguard I added should be improve... (i.e.: have them only MOAB download is triggered...)

cmake/FindMOAB.cmake

bam241 · 2024-12-06T06:55:21Z

@gonuke this still needs some polishing here and there, but I think this is ready for a first opinion.

ahnaf-tahmid-chowdhury

Thank you very much for the update. I have a few comments for improvement.

cmake/DAGMC_macros.cmake

cmake/MOAB_PullAndMake.cmake

ahnaf-tahmid-chowdhury · 2024-12-06T12:19:53Z

cmake/MOAB_PullAndMake.cmake

+        -DBUILD_SHARED_LIBS:BOOL=ON
+        -DENABLE_HDF5:BOOL=ON
+        -DHDF5_ROOT:PATH=${HDF5_ROOT}
+        -DCMAKE_INSTALL_RPATH=${HDF5_ROOT}/lib:${MOAB_INSTALL_PREFIX}/lib


This method may work here for now, but may create trouble while working with scikit-build-core depended project. However, I am not sure here.

I have no experience about scikit-build-core, maybe we shall fix it, if the problem occurs ?

I believe MOAB master branch now has scikit-build core while version 5.5.1 does not.

Perhaps changing the moab version to master would provide a quick way of checking if this continues to work

GIT_REPOSITORY https://bitbucket.org/fathomteam/moab.git GIT_TAG ${moab_version}

Trying it now.

Just to mention @bam241 tried this with the master branch of MOAB (which has scikit build core) and reported that it works

have a doubt about what I did, I'll try one more time

Any final resolution on this?

I have tested this against MOAB master, this works.

Test on 5fe643b
checked the proper work of this against MOAB Master branch

ahnaf-tahmid-chowdhury · 2024-12-06T12:21:00Z

.github/workflows/linux_build_test.yml

@@ -50,6 +50,9 @@ jobs:
          5.4.1,
          5.5.1,
        ]
+        ddl_deps : [


What is the use of it?

This is like Enable Download MOAB or Double Down?

this only enables MOAB Download, otherwise everything work as it used to.

I don't have a strong opinion about the name of the variable,
but eventually one might want to include Embree and DD the same way...

if your question is about the addition into the matrix, I needed it to allow the CI to test for this kind of build...

this seems to pass, I'll revert the change

jon-proximafusion · 2024-12-10T12:19:18Z

Testing locally with this docker file and it compiles for me
Note this points to Bam's fork and this PR branch
Also note, this example is very minimal with no DD, Embree, Pyne

FROM ubuntu:24.04

RUN apt-get update -y
RUN apt-get install git cmake libhdf5-serial-dev g++ libeigen3-dev -y 

RUN mkdir DAGMC && \
	cd DAGMC && \
	git clone --single-branch --branch auto_moab --depth 1 https://github.com/bam241/DAGMC.git && \
	mkdir build && \
	cd build && \
	cmake ../DAGMC -DBUILD_TALLY=ON \
                   -DBUILD_STATIC_EXE=OFF \
                   -DBUILD_STATIC_LIBS=OFF \
                   -DCMAKE_INSTALL_PREFIX=/DAGMC/ \
                   -DBUILD_UWUW=OFF \
                   -DDDL_INSTALL_DEPS=ON && \
	make -j install

cmake/MOAB_PullAndMake.cmake

bam241 · 2024-12-12T11:08:30Z

Test on 5fe643b
checked the proper work of this against MOAB Master branch

change location cmake up cmake up cmake up CMAKE_MODULE_PATH CMAKE_MODULE_PATH CMAKE_MODULE_PATH adding LIBS adding LIBS install_dependent_library(MOAB ) install_dependent_library adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE tmp get the safeguard revert unnecessary change

Co-authored-by: Jonathan Shimwell <[email protected]>

jon-proximafusion · 2025-01-09T16:43:13Z

IMO this PR makes building DAGMC easier for users. Currently we ask users to compile MOAB and then compile DAGMC passing some of the info on MOAB to the DAGMC compile. I believe the current situation is overly complicated.

This PR simplifies the compile for users which I think will be appreciated and lowers the bar slightly for installing DAGMC which might help bring in a few more users.

Additionally it retains backwards compatibility so if someone does what to compile both MOAB and DAGMC in the current way then they can still do that.

The main change I would suggest is that we make the pull_install_moab variable accept a version number of MOAB and default to the current latest. This would offer greater user control over the automated download. However that could be a follow up PR if desired.

gonuke

A few comments trying to streamline and localize these changes.

CMakeLists.txt

gonuke · 2025-01-09T17:10:51Z

cmake/FindMOAB.cmake

Since we're including and running another macro here now, can we add a comment at the top of this that lists all the variables that expect to be set once this FindMOAB is complete? Then we can make sure the same/similar comment is at the top of that new macro.

gonuke · 2025-01-09T17:11:58Z

cmake/FindMOAB.cmake

-if (MOAB_CMAKE_CONFIG)
+
+# First check if we are forcing the download of MOAB
+if (PULL_INSTALL_MOAB)


Have we thought about whether we put this condition up one level? That is, if we are going to PULL_INSTALL, then we don't call FindPackage at all and just do this macro instead? Then we don't need to mess with the FindMOAB file. I think that will work???

pshriwise

I'm nominally on board here and want to make the installation process easier, but I do have concerns. There are secondary dependencies to consider and how we might specify those to the direct dependencies of MOAB. For example, there's a requirement here for an HDF5_ROOT that's expected to be set prior to the CMake call (from what I can tell).

I think what's here really would make the installation process better for all, but I do want to think through these scenarios thoroughly.

pshriwise · 2025-01-09T17:55:11Z

src/mcnp/CMakeLists.txt

@@ -18,6 +18,11 @@ add_library(mcnp_funcs OBJECT mcnp_funcs.cpp)
 message(STATUS "Building object library: meshtal_funcs")
 add_library(meshtal_funcs OBJECT meshtal_funcs.cpp)

+if(PULL_INSTALL_MOAB)


I'm curious as to why these lines are needed now when they weren't before.

The goal is to allow if asked for, the possibility to pull and compile MOAB at the DAGMC build time

This variable has been added to detect if such auto download and compilation of MOAB is requested.

pshriwise · 2025-01-09T17:55:21Z

cmake/MOAB_PullAndMake.cmake

+        -DBUILD_SHARED_LIBS:BOOL=ON
+        -DENABLE_HDF5:BOOL=ON
+        -DHDF5_ROOT:PATH=${HDF5_ROOT}
+        -DCMAKE_INSTALL_RPATH=${HDF5_ROOT}/lib:${MOAB_INSTALL_PREFIX}/lib


Any final resolution on this?

pshriwise

Sorry, meant to comment not approve.. yet 😄

bam241 · 2025-01-09T18:14:45Z

💔

makeclean · 2025-01-10T09:20:30Z

IMO you should also add -DENABLE_FORTRAN=OFF, -DENABLE_BLASLAPCK=OFF you might need to pass an EIGEN3_DIR or something

bam241 · 2025-01-10T13:09:26Z

@gonuke, I moved this 1 level.

I added a HDF5_macor.cmake file that factories HDF5 search and variables definition.

bam241 commented Dec 4, 2024

View reviewed changes

src/pyne/CMakeLists.txt Outdated Show resolved Hide resolved

bam241 commented Dec 4, 2024

View reviewed changes

src/dagmc/CMakeLists.txt Outdated Show resolved Hide resolved

bam241 commented Dec 4, 2024

View reviewed changes

jon-proximafusion mentioned this pull request Dec 5, 2024

updated cmake min version to 3.18 #970

Closed

shimwell reviewed Dec 5, 2024

View reviewed changes

cmake/FindMOAB.cmake Outdated Show resolved Hide resolved

shimwell reviewed Dec 5, 2024

View reviewed changes

cmake/FindMOAB.cmake Outdated Show resolved Hide resolved

bam241 force-pushed the auto_moab branch from 8761cb8 to c20a90e Compare December 6, 2024 05:31

bam241 marked this pull request as ready for review December 6, 2024 06:42

bam241 requested a review from gonuke December 6, 2024 06:54

bam241 force-pushed the auto_moab branch 2 times, most recently from d49d208 to 45feb89 Compare December 6, 2024 11:32

ahnaf-tahmid-chowdhury reviewed Dec 6, 2024

View reviewed changes

jon-proximafusion reviewed Dec 12, 2024

View reviewed changes

cmake/MOAB_PullAndMake.cmake Outdated Show resolved Hide resolved

jon-proximafusion reviewed Dec 12, 2024

View reviewed changes

cmake/MOAB_PullAndMake.cmake Outdated Show resolved Hide resolved

bam241 force-pushed the auto_moab branch from 4be94aa to 17d11d1 Compare December 12, 2024 10:58

shimwell mentioned this pull request Dec 12, 2024

Fetch DAGMC if not found in cmakelists.txt openmc-dev/openmc#3193

Draft

5 tasks

bam241 and others added 9 commits January 9, 2025 15:19

Update cmake/FindMOAB.cmake

a5e83e3

Co-authored-by: Jonathan Shimwell <[email protected]>

Update cmake/FindMOAB.cmake

b28d951

Co-authored-by: Jonathan Shimwell <[email protected]>

reformating + changelog + tests

26e03af

add missing indent

0908fdd

generalyze shared lib extention

83ca15e

temporary change to master

c6df67a

back to 5.5.1

853b3b9

adding DDL_INSTALL_DEPS as an option with default to OFF

612893a

bam241 added 4 commits January 9, 2025 15:19

keeping jon changes

b012285

trying MOAB master

bbe4828

reverting to 5.5.1 as default version for MOAB

ef5a2e0

cleaning variable name

6675cef

bam241 force-pushed the auto_moab branch from b86a8a6 to 6675cef Compare January 9, 2025 14:20

gonuke requested changes Jan 9, 2025

View reviewed changes

pshriwise previously approved these changes Jan 9, 2025

View reviewed changes

pshriwise reviewed Jan 9, 2025

View reviewed changes

moving this up one level

19da17b

bam241 dismissed pshriwise’s stale review via 19da17b January 10, 2025 12:02

bam241 added 6 commits January 10, 2025 13:04

missing a )

bf4ecff

cmake likes set to define variables

ef2c3e5

no need for MOAB_VERSION

e7a03fd

how about now ?

5907867

how about now ?

8a8597d

no caps for include folder

9d4ccc0

revamping find_MOAB

445aab9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automatic download and build of MOAB #969

Automatic download and build of MOAB #969

bam241 commented Dec 4, 2024 •

edited

Loading

bam241 commented Dec 4, 2024

bam241 Dec 4, 2024

bam241 commented Dec 4, 2024 •

edited

Loading

bam241 commented Dec 6, 2024

ahnaf-tahmid-chowdhury left a comment

ahnaf-tahmid-chowdhury Dec 6, 2024

bam241 Dec 6, 2024

shimwell Dec 6, 2024

bam241 Dec 6, 2024

jon-proximafusion Dec 12, 2024

bam241 Dec 12, 2024

pshriwise Jan 9, 2025

bam241 Jan 10, 2025

ahnaf-tahmid-chowdhury Dec 6, 2024

ahnaf-tahmid-chowdhury Dec 6, 2024

bam241 Dec 6, 2024

bam241 Dec 6, 2024

bam241 Dec 6, 2024

jon-proximafusion commented Dec 10, 2024 •

edited

Loading

bam241 commented Dec 12, 2024

jon-proximafusion commented Jan 9, 2025

gonuke left a comment

gonuke Jan 9, 2025

gonuke Jan 9, 2025

pshriwise left a comment

pshriwise Jan 9, 2025

bam241 Jan 10, 2025

pshriwise Jan 9, 2025

pshriwise left a comment

bam241 commented Jan 9, 2025

makeclean commented Jan 10, 2025

bam241 commented Jan 10, 2025

Automatic download and build of MOAB #969

Are you sure you want to change the base?

Automatic download and build of MOAB #969

Conversation

bam241 commented Dec 4, 2024 • edited Loading

Description

Motivation and Context

Changes

Behavior

Changelog file

bam241 commented Dec 4, 2024

Choose a reason for hiding this comment

bam241 commented Dec 4, 2024 • edited Loading

bam241 commented Dec 6, 2024

ahnaf-tahmid-chowdhury left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jon-proximafusion commented Dec 10, 2024 • edited Loading

bam241 commented Dec 12, 2024

jon-proximafusion commented Jan 9, 2025

gonuke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pshriwise left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pshriwise left a comment

Choose a reason for hiding this comment

bam241 commented Jan 9, 2025

makeclean commented Jan 10, 2025

bam241 commented Jan 10, 2025

bam241 commented Dec 4, 2024 •

edited

Loading

bam241 commented Dec 4, 2024 •

edited

Loading

jon-proximafusion commented Dec 10, 2024 •

edited

Loading