Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Vercel, Cloudflare, and Netlify adapter major versions #13142

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Dec 11, 2024

fixes #13314

This PR updates the installed versions of the Vercel, Cloudflare, and Netlify adapters to use their latest versions.

A fresh project created by pnpx sv create using adapter-auto fails on Vercel because it uses Node 22 in build environment but installs an old version of the adapter which is incompatible with Node 22

I wasn't sure about the changeset version or message for this one. Please feel free to correct it.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: c8f0f62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-auto Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13142-svelte.vercel.app/

this is an automated message

@benmccann
Copy link
Member

Is there some sort of test we could add to prevent this in the future? It seems like a hard to thing to remember to update

@eltigerchino
Copy link
Member Author

eltigerchino commented Dec 16, 2024

Is there some sort of test we could add to prevent this in the future? It seems like a hard to thing to remember to update

Good idea. I've added a test that checks if each auto installable adapter uses the latest major.

@eltigerchino eltigerchino changed the title chore: update Vercel, Cloudflare, and Netlify adapter versions feat: update Vercel, Cloudflare, and Netlify adapter major versions Jan 15, 2025
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea with the test!

@dummdidumm dummdidumm merged commit d512606 into main Jan 15, 2025
14 checks passed
@dummdidumm dummdidumm deleted the update-adapter-auto-versions branch January 15, 2025 07:15
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
arcataroger added a commit to datocms/sveltekit-starter-kit that referenced this pull request Jan 15, 2025
Fixes #3. Svelte upstream fixed the issue in sveltejs/kit#13142.
@arcataroger
Copy link

@eltigerchino and @dummdidumm, thanks so much for this fix and quick merge!

@manuel3108
Copy link
Member

Thanks to @hyunbinseo who also prepared sveltejs/cli#401 so that the latest version of sv should work out of the box now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sveltejs/[email protected] installs @sveltejs/adapter-vercel@4, which doesn't support Node 22
6 participants