-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update Vercel, Cloudflare, and Netlify adapter major versions #13142
Conversation
🦋 Changeset detectedLatest commit: c8f0f62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-kit-13142-svelte.vercel.app/ this is an automated message |
Is there some sort of test we could add to prevent this in the future? It seems like a hard to thing to remember to update |
Good idea. I've added a test that checks if each auto installable adapter uses the latest major. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea with the test!
Fixes #3. Svelte upstream fixed the issue in sveltejs/kit#13142.
@eltigerchino and @dummdidumm, thanks so much for this fix and quick merge! |
Thanks to @hyunbinseo who also prepared sveltejs/cli#401 so that the latest version of |
fixes #13314
This PR updates the installed versions of the Vercel, Cloudflare, and Netlify adapters to use their latest versions.
A fresh project created by
pnpx sv create
using adapter-auto fails on Vercel because it uses Node 22 in build environment but installs an old version of the adapter which is incompatible with Node 22I wasn't sure about the changeset version or message for this one. Please feel free to correct it.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits