Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Upgrade rollup-plugin-css-chunks #1666

Merged
merged 1 commit into from
Dec 25, 2020

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Dec 10, 2020

Fixes #1564

This is a breaking change, so the next release would have to be Sapper 0.29.0. See domingues/rollup-plugin-css-chunks#17

@Conduitry
Copy link
Member

Is this pending the merge and release of domingues/rollup-plugin-css-chunks#17 ? Would that then be version 3 of that plugin? Or was version 2 the breaking change, and that PR is just fixing the peerdep ranges to match what it already requires?

@benmccann
Copy link
Member Author

Version 2 was the breaking change and that PR is just fixing the peerDependencies

@benmccann benmccann force-pushed the rollup-plugin-css-chunks branch from dc819cf to 8bb5f9d Compare December 10, 2020 22:17
@benmccann benmccann added breaking Breaking Changes bug bundling dependencies Pull requests that update a dependency file labels Dec 14, 2020
@benmccann
Copy link
Member Author

@Conduitry are you okay if I merge this and we make the next release 0.29 with this breaking change? I'd like to get some more eyes on the new version of the css plugin since it's used by SvelteKit as well

@Conduitry
Copy link
Member

I'm fine with this change, but are there other breaking changes we should get cued up for a new version?

@benmccann benmccann mentioned this pull request Dec 14, 2020
@benmccann
Copy link
Member Author

There were a few other breaking changes I was originally considering before SvelteKit came along: #1545.
There's no PR available for the segment prop change, so I'm not sure that's something that would get done.
Reverting #1244 and merging #1566 probably make sense though

@benmccann benmccann merged commit 8a2769d into sveltejs:master Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking Changes bug bundling dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"phantom" modules appearing with recent rollup versions.
2 participants