fix: value/checked not correctly set using spread #15239
Merged
+68
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #15237 : "Using spread syntax '{...rest }' with props doesnt work correctly!"
Note : the issue is about the input input text
value
, but there's the same problem withchecked
.set_attributes()
useremoveAttributes()
which removes the attribute without impacting the JS state ofvalue/checked
, so the result is not constant.This work only on the initial state, but not when the
value/checked
was previously set by JavaScript.=> The
value/checked
properties must be set explicitly.Note : I not launched lint and all tests because it generates strange errors on my config (before any change in the code).
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint