Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: value/checked not correctly set using spread #15239

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

adiguba
Copy link
Contributor

@adiguba adiguba commented Feb 7, 2025

Fix issue #15237 : "Using spread syntax '{...rest }' with props doesnt work correctly!"

Note : the issue is about the input input text value, but there's the same problem with checked.

set_attributes() use removeAttributes() which removes the attribute without impacting the JS state of value/checked, so the result is not constant.
This work only on the initial state, but not when the value/checked was previously set by JavaScript.

=> The value/checked properties must be set explicitly.

Note : I not launched lint and all tests because it generates strange errors on my config (before any change in the code).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 0531f27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15239

@adiguba
Copy link
Contributor Author

adiguba commented Feb 7, 2025

added a fix for test form-default-value-spread : on initial rendering a null/undefined will use the value from defaultValue/defaultChecked

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I tested it out locally and it works really well, thank you for this fix :)

@trueadm trueadm merged commit afae274 into sveltejs:main Feb 11, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants