Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Jackson 2.11.0 #3576

Closed
wants to merge 2 commits into from
Closed

Update to Jackson 2.11.0 #3576

wants to merge 2 commits into from

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Jun 3, 2020 •
edited
Loading

  • Update to Jackson 2.11.0
  • Make tests independent of YAML formatting (whitespace, single/double quotes)

Refs #3554
Closes #3531

joschi added 2 commits June 3, 2020 17:48
@joschi
Update to Jackson 2.11.0
3d3395f 
* Make tests independent of YAML formatting (whitespace, quotes)
@joschi
Merge branch 'master' into jackson-2.11.0
fbe11d7
@joschi joschi marked this pull request as ready for review June 3, 2020 15:56
@frantuma frantuma self-assigned this Jun 3, 2020
@frantuma frantuma added this to the M3 milestone Jun 3, 2020
@frantuma
Copy link
Member

frantuma commented Jun 3, 2020

not sure here, 2 thoughts:

  1. the change introduces a "more relaxed" check which would e.g not cover changes like the ones discussed in Fix deserializing enum with negative Long values #3544; while this is already true for many tests where compareAsYaml or equivalent is used, the ones doing string comparison still provide final output comparison.

  2. still I'd wait for outcome of Improve MINIMIZE_QUOTES handling to avoid quoting for some use of # and : FasterXML/jackson-dataformats-text#201, to possibly switch directly to 2.11.1

@joschi
Copy link
Contributor Author

joschi commented Jun 4, 2020

With FasterXML/jackson-dataformats-text#201 merged and scheduled for Jackson 2.11.1, I would also close this PR and upgrade directly to Jackson 2.11.1 once it has been released. 👍

@joschi joschi closed this Jun 4, 2020
@joschi joschi deleted the jackson-2.11.0 branch June 4, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frantuma frantuma

Labels
None yet
Projects
None yet
Milestone
M3
Development

Successfully merging this pull request may close these issues.
2 participants
@joschi @frantuma