use string typed enum ChainId

swapnet-xyz · Nov 14, 2024 · 8d7e20c · 8d7e20c
1 parent eba8d54
commit 8d7e20c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/common/unames.ts b/src/common/unames.ts
@@ -1,11 +1,11 @@
 
 
 export enum ChainId {
-    EthereumMainnet = 1,
-    ArbitrumOne = 42161,
-    BaseMainnet = 8453,
-    BlastMainnet = 81457,
-    SuiMainnet = 101,
+    EthereumMainnet = "1",
+    ArbitrumOne = "42161",
+    BaseMainnet = "8453",
+    BlastMainnet = "81457",
+    SuiMainnet = "101",
 };
 
 export enum LiquiditySourceUname {

diff --git a/src/routers/universalRouter/index.ts b/src/routers/universalRouter/index.ts
@@ -17,7 +17,7 @@ import { universalRouterPluginByLiquiditySourceUname } from '../../liquiditySour
 const universalRouterInterface: Interface = new Interface(universalRouterData.abi);
 
 export class UniversalRouter extends RouterBase {
-    public constructor(_chainId: number, _routerAddress: string, _tokenProxyAddress: string = PERMIT2_ADDRESS) {
+    public constructor(_chainId: ChainId, _routerAddress: string, _tokenProxyAddress: string = PERMIT2_ADDRESS) {
         super(universalRouterUname, _chainId, _routerAddress, _tokenProxyAddress);
     }
 
@@ -118,7 +118,7 @@ export class UniversalRouter extends RouterBase {
 
 export const universalRouterByChainId: Map<ChainId, UniversalRouter> = new Map();
 
-Object.entries(deployedAddressesByChainId).map(([chainIdStr, routerAddress]) => {
-    const chainId: ChainId = parseInt(chainIdStr);
+Object.entries(deployedAddressesByChainId).map(([chainIdString, routerAddress]) => {
+    const chainId = chainIdString as ChainId;
     universalRouterByChainId.set(chainId, new UniversalRouter(chainId, routerAddress));
 });