Expose sandbox properties via IPC JSON, criteria, title format #8521
+227
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobmcnamee
force-pushed
the
sandbox_properties
branch
from
270600d to
f4af2ca
Compare
emersion
reviewed
Jan 8, 2025
| static const struct wlr_security_context_v1_state *security_context_from_view( | ||
| struct sway_view *view) { | ||
| const struct wl_client *client = | ||
| wl_resource_get_client(view->surface->resource); |
There was a problem hiding this comment.
It seems like this has nothing xdg-shell specific - do we really need to get through the view->impl abstraction, or can we just put this logic in generic view code?
emersion
reviewed
Jan 8, 2025
| @@ -602,6 +602,18 @@ static void ipc_json_describe_view(struct sway_container *c, json_object *object | |||
| json_object_object_add(object, "inhibit_idle", | |||
| json_object_new_boolean(view_inhibit_idle(c->view))); | |||
|
|
|||
| const char *sandbox_engine = view_get_sandbox_engine(c->view); | |||
| json_object_object_add(object, "sandbox_engine", | |||
There was a problem hiding this comment.
Seems like we should be adding these new props to the IPC man page as well.
emersion
reviewed
Jan 8, 2025
| If the value is \_\_focused\_\_, then the sandbox engine must be the same as | ||
| that of the currently focused window. | ||
|
|
||
| *sandbox_app_id* |
There was a problem hiding this comment.
I'm kind of wondering whether we should expose this, or whether we should always prefer the sandbox-provided app ID over the one provided by the sandboxed client.
(IIRC GNOME allows org.libreoffice.Writer if the sandbox app ID is org.libreoffice.)
emersion
reviewed
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase and update of #7187.
Add sandbox properties to IPC JSON, criteria, and title format:
sandbox_enginesandbox_app_idsandbox_instance_idThese properties may be set by sandbox engines (e.g.
flatpak) via the security context protocol: https://wayland.app/protocols/security-context-v1.Example Usage
Prepend sandbox properties to window title when sandbox engine is set:
Testing
Launch an app via
flatpak:Observe JSON layout tree via
swaymsg -r -t get_tree:Observe pretty layout tree via
swaymsg -p -t get_tree:Observe window title when configured as shown above: