Fingerprint support #283
Open
Fingerprint support #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI (builds.sr.ht) compiles wrong version. It seems it compiles only master, not selected commit. Is it okay? |
|
Hm, do we really all of this complexity? I'd rather not do any of the D-Bus stuff. Can't users leverage a PAM module which integrates with the fingerprint reader instead? |
Yes, we want to check password and fingerprint in parallel. With Pam closest solution is check fingerprint after empty password was entered. With this MR we can touch fingerprint scanner while PC is asleep, it will wake up over USB and immediately unlock without necessety to press any button. |
|
I am not sure I want to maintain this upstream. |
Okay, I'll maintain it as a fork |
|
I was curious about the fork, @SL-RU : does it need to be tightly integrated with the code of swaylock? Or can it be a separate stand-alone program that interfaces just with the new wlroots lock protocol, and run in parallel with swaylock? |
Really sad to hear that, the new implementation is really awesome for daily users. Would it be an option to make @SL-RU a maintainer so that it's included but mostly maintained by him if he is even ok with maintaining a fork? Deleted my last comment after that as it was an system-issue not related to the code/fork. |
12 tasks
If this works like a plugin it would be great. I already use https://github.com/mortie/swaylock-effects. |
|
@lack @paulodiovani currently code is tightly integrated with swaylock, but mainly just for indication. It can be separated into separate service. What is new wlroots lock protocol? How swaylock uses it and how fprintd service will interact with it? |
ext-session-lock-v1, already implemented in swaylock and only affects how lock screens open a lock surface. |
|
I guess what I was thinking of may not even need any knowledge of the lock protocol; but instead of implementing the fingerprint integrated into swaylock it could be an external program that:
Then:
The only thing lost in this approach is a way to have user feedback in swaylock itself if the fingerprint read was attempted and failed... |
The PAM fingerprint module (from libfprint) relies on libfprintd which depends on polkit which requires systemd. So it's not portable and won't work on many configurations. That said, this implementation relies on I do think that the approach mentioned by @lack makes a lot of sense. I wonder if we could use SIGUSR2 to signal to the user "failed attempt" for out-of-band unlock attempts. |
Hey, I tried to implement this - it generally works but I sometimes get random crashes (after more than one SIGUSR2 signals) and tried to debug it with the Current Status: https://github.com/SebTM/swaylock/tree/feature/sigusr2 Log from a crash: Maybe someone can have a look as my C skills are very elementary... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added fingerprint support via fprintd daemon which has DBus communication and because of that build dependencies was added(
dbus,gio,fprintdand etc), but they are not required for execution. To run swaylock with fprintd you need to start fprintd and then swaylock with argument-por--fingerprintCan you make a review and say is merge possible?
Package with fingerprint support on AUR: https://aur.archlinux.org/packages/swaylock-fprintd-git
This relates to #61