Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in range_overlap changes from @DamienIrving #1072

Closed
wants to merge 1 commit into from

Conversation

tmorrell
Copy link

@tmorrell tmorrell commented Nov 9, 2023

This pull requests extracts a small portion of the changes from #981 and updates them to the workbench format. All the text is from @DamienIrving

The motivation to add this change separately is currently the range_overlap exercise ends partly through without providing a actual solution. These changes provide the final solution and a much better walkthrough, and are independent from the discussion of exceptions and assertions.

Copy link

github-actions bot commented Nov 9, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-inflammation/compare/md-outputs..md-outputs-PR-1072

The following changes were observed in the rendered markdown documents:

 10-defensive.md | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 md5sum.txt      |  2 +-
 2 files changed, 68 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-10 14:19:01 +0000

github-actions bot pushed a commit that referenced this pull request Nov 10, 2023
Copy link
Member

@ineelhere ineelhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the efforts and contribution.
The PR, on comparison, seems to need more modifications with reference to PR #981. Let us please refer to the PR files and kindly address all changes as approved on PR #981 for a successful merge. Thank you and best wishes! 🙂

@tmorrell
Copy link
Author

Thanks @ineelhere. My motivation for splitting up the contents of #981 was to make it easier to merge. The changes to range_overlap are really independent of everything else in #981, and I think others should propose/promote the change from exceptions to assertions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants