-
Notifications
You must be signed in to change notification settings - Fork 86
I181 glo decoder python binding #340
base: master
Are you sure you want to change the base?
I181 glo decoder python binding #340
Conversation
baba16f
to
c9a1f43
Compare
@gsmcmullin Please review. All dependencies are now satisfied. |
maintainer = 'Swift Navigation', | ||
maintainer_email = '[email protected]', | ||
packages = ['swiftnav'], | ||
name='swiftnav', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there extra spaces here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting has changed to to auto-formatting (autopep.8 --indent-size 2). Shall it be 2 here and below? Do we have any other non-default settings (other than indentation size)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I will ask... @benjamin0 Do you know what the story is with our Python formatting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valeri-atamaniouk looks like it should be two spaced ident
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ljbade @benjamin0 https://www.python.org/dev/peps/pep-0008/#id3
https://www.python.org/dev/peps/pep-0008/#fn-hi
-Hanging indents should add a level
The issue is related to PEP8 conformance of E121 and E126. I suggest to update the coding style to mention that hanging indents are 2 spaces. It would make it impossible to use auto-indentation, but I'm perfectly fine with that.
For example, when using pep8 to check the style with only 2 spaces in hanging indents:
$ pep8 --ignore E111,E114 setup.py
setup.py:5:3: E121 continuation line under-indented for hanging indent
setup.py:55:7: E121 continuation line under-indented for hanging indent
setup.py:63:5: E121 continuation line under-indented for hanging indent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if hanging indents should add a level
and we define a level as indented two spaces, then hanging indents are an additional 2 spaces. @valeri-atamaniouk feel free to update the linked hackpad above. @fnoble do you have an opinion?
c9a1f43
to
b58bf98
Compare
Added Python bindings for GLONASS message decoder operations.
b58bf98
to
6e3c44a
Compare
Python bindings for GLONASS message decoder
To be merged after #337