Ensure URLSessionDataTask response is not dropped #5167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We seem to be dropping the response in this case, just ensure we actually save it after the transfer has completed.
harlanhaskins
force-pushed
the
harlan/ts-eliot
branch
from
83c610e to
eb9f6ca
Compare
|
@swift-ci please test |
harlanhaskins
force-pushed
the
harlan/ts-eliot
branch
from
eb9f6ca to
13245b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code seems to have been attempting to resolve the completed response at the end of the transfer, but it was creating a local copy and mutating that instead of mutating the transfer state we're currently looking at. This seems to happen when a header is truncated? I'm not exactly sure, but this code looked incorrect on inspection.
Still testing this fix locally.
This should fix #4052