[6.1] Fix the Publish Release workflow
#891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
Dec 5, 2024
ahoppen
commented
- Explanation: Fix the Publish Release workflow to allow us to create (pre-)releases of swift-format using GitHub Actions again
- Scope: GitHub workflow that’s manually invoked
- Risk: None, doesn’t affect the toolchain build
- Testing: Tested the workflow on my own branch (https://github.com/ahoppen/swift-format/actions/runs/12170672520)
- Issue: n/a
- Reviewer: @shahmishal on Run Windows tests before tagging a release #863 and Bugfixes for the publish release workflow #890
The GitHub workflows enabled Windows in the testing matrix. We needed to port the pre-build commands that apply the release commits to Windows to make the Windows checks pass.
bnbarham
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.