Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: re-enable testing for libdispatch in build.ps1 #78685

Merged

Conversation

weliveindetail
Copy link
Member

We lost libdispatch testing (by accident I guess) in 9819577

@weliveindetail
Copy link
Member Author

@swift-ci please test

Copy link
Member Author

@weliveindetail weliveindetail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failed in swift-tools-support-core with errors like:

 11 | import Foundation
    |        `- error: missing required module 'Dispatch'

This build-step depends on libdispatch:

find_package(dispatch QUIET)

Interestingly, the same issue didn't pop up in earlier build-steps like swift-testing or swift-corelibs-foundation. They both run find_package in CONFIG mode:

find_package(dispatch CONFIG)

Are they using a different libdispatch? Edit: Apparently, they found the one from the host runtime (not desirable)

@@ -1862,6 +1862,7 @@ function Build-Dispatch([Platform]$Platform, $Arch, [switch]$Test = $false) {
-InstallTo $InstallPath `
-Arch $Arch `
-Platform $Platform `
-BuildTargets $Targets `
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further investigation shows that my change had the side-effect that we no longer built the install target for libdispatch:

    # Build all requested targets
    foreach ($Target in $BuildTargets) {
      if ($Target -eq "default") {
        Invoke-Program cmake.exe --build $Bin
      } else {
        Invoke-Program cmake.exe --build $Bin --target $Target
      }
    }
    if ($BuildTargets.Length -eq 0 -and $InstallTo) {
      Invoke-Program cmake.exe --build $Bin --target install
    }

I assume this is what we actually want.

@weliveindetail
Copy link
Member Author

@swift-ci please test

@weliveindetail
Copy link
Member Author

Build failed in swift-docc on Linux with:

114 |             promise.futureResult.assumeIsolated().whenComplete { _ in context.close(promise: nil) }
    |                                  `- error: 'assumeIsolated' is inaccessible due to 'internal' protection level

This is unrelated. Linux bots are failing since: https://ci.swift.org/view/Dashboard/job/oss-swift-RA-linux-ubuntu-22_04/8500

@weliveindetail
Copy link
Member Author

Same issue on macOS. Today everything is upside-down: Windows works, the others fail 😂 Will land it next week.

@weliveindetail
Copy link
Member Author

@swift-ci please test

@weliveindetail weliveindetail enabled auto-merge (squash) January 21, 2025 16:23
@weliveindetail
Copy link
Member Author

Builds for macOS and Linux didn't start. Let's try that again.

@swift-ci please smoke test

@weliveindetail
Copy link
Member Author

Windows failed due to one test failure in Swift. This is unrelated:

Failed Tests (1):
  Swift-Unit :: SourceKit/SwiftLang/./SourceKitSwiftLangTests.exe/9/26

The two other bots are not reachable (502):
https://ci.swift.org/job/swift-PR-macos-smoke-test/
https://ci.swift.org/job/swift-PR-macos-smoke-test/

@weliveindetail
Copy link
Member Author

@swift-ci please smoke test

@weliveindetail weliveindetail merged commit 7bbd5d7 into swiftlang:main Jan 23, 2025
3 of 5 checks passed
@weliveindetail weliveindetail deleted the testing-reenable-libdispatch branch January 24, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants