-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils: re-enable testing for libdispatch in build.ps1 #78685
utils: re-enable testing for libdispatch in build.ps1 #78685
Conversation
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build failed in swift-tools-support-core with errors like:
11 | import Foundation
| `- error: missing required module 'Dispatch'
This build-step depends on libdispatch:
find_package(dispatch QUIET)
Interestingly, the same issue didn't pop up in earlier build-steps like swift-testing or swift-corelibs-foundation. They both run find_package in CONFIG mode:
find_package(dispatch CONFIG)
Are they using a different libdispatch? Edit: Apparently, they found the one from the host runtime (not desirable)
@@ -1862,6 +1862,7 @@ function Build-Dispatch([Platform]$Platform, $Arch, [switch]$Test = $false) { | |||
-InstallTo $InstallPath ` | |||
-Arch $Arch ` | |||
-Platform $Platform ` | |||
-BuildTargets $Targets ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further investigation shows that my change had the side-effect that we no longer built the install
target for libdispatch:
# Build all requested targets
foreach ($Target in $BuildTargets) {
if ($Target -eq "default") {
Invoke-Program cmake.exe --build $Bin
} else {
Invoke-Program cmake.exe --build $Bin --target $Target
}
}
if ($BuildTargets.Length -eq 0 -and $InstallTo) {
Invoke-Program cmake.exe --build $Bin --target install
}
I assume this is what we actually want.
@swift-ci please test |
Build failed in swift-docc on Linux with:
This is unrelated. Linux bots are failing since: https://ci.swift.org/view/Dashboard/job/oss-swift-RA-linux-ubuntu-22_04/8500 |
Same issue on macOS. Today everything is upside-down: Windows works, the others fail 😂 Will land it next week. |
@swift-ci please test |
Builds for macOS and Linux didn't start. Let's try that again. @swift-ci please smoke test |
Windows failed due to one test failure in Swift. This is unrelated:
The two other bots are not reachable (502): |
@swift-ci please smoke test |
We lost libdispatch testing (by accident I guess) in 9819577