Sema: Fix missing source loc in actor isolation diagnostics around @dynamicMemberLookup key paths
#78871
+111
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
ktoso,
slavapestov,
hborla,
xedin,
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder and
Xazax-hun
as code owners
|
@swift-ci please smoke test macOS |
xedin
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
I think it's the same situation as implicit vs. implicit + synthesized specially visible in derived synthesis related changes, we might want to consider splitting API into forImplicitSingle that always has a loc and forSynthesizedSingle that can default an an empty one.
|
@swift-ci please test macOS platform |
Xazax-hun
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://129310334
This is a targeted fix. The takeaway is that implicit != no source location.