Tests: Test conformance checker with witnesses in unavailable extensions #78872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
AnthonyLatsis,
hborla and
slavapestov
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
…ons. A protocol conformance witness must be as available as its requirement. In Swift 6.1 and earlier, the conformance checker failed to note that witnesses in unavailable extensions are unavailable. That bug was fixed by a previous change, but there was no test case covering it so the difference in behavior was not acknowledged. Related to rdar://143466010.
tshortli
force-pushed
the
unavailable-witness-in-extension-diag-regression-test
branch
from
221a7a2 to
fdcf53c
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please test Windows |
tshortli
deleted the
unavailable-witness-in-extension-diag-regression-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A protocol conformance witness must be as available as its requirement. In Swift 6.1 and earlier, the conformance checker failed to note that witnesses in unavailable extensions are unavailable. That bug was fixed by a previous change, but there was no test case covering it so the difference in behavior was not acknowledged.
Related to rdar://143466010.