fix: before_ext should exclude directories since only files have ex…

…tensions (#2132)

Cargo.toml

@@ -11,7 +11,7 @@ strip         = true
 
 [workspace.dependencies]
 ansi-to-tui   = "7.0.0"
-anyhow        = "1.0.94"
+anyhow        = "1.0.95"
 base64        = "0.22.1"
 bitflags      = "2.6.0"
 clap          = { version = "4.5.23", features = [ "derive" ] }
@@ -26,8 +26,8 @@ parking_lot   = "0.12.3"
 ratatui       = { version = "0.29.0", features = [ "unstable-rendered-line-info" ] }
 regex         = "1.11.1"
 scopeguard    = "1.2.0"
-serde         = { version = "1.0.216", features = [ "derive" ] }
-serde_json    = "1.0.133"
+serde         = { version = "1.0.217", features = [ "derive" ] }
+serde_json    = "1.0.134"
 shell-words   = "1.1.0"
 tokio         = { version = "1.42.0", features = [ "full" ] }
 tokio-stream  = "0.1.17"

yazi-codegen/Cargo.toml

@@ -13,5 +13,5 @@ proc-macro = true
 
 [dependencies]
 # External dependencies
-syn   = { version = "2.0.90", features = [ "full" ] }
-quote = "1.0.37"
+syn   = { version = "2.0.93", features = [ "full" ] }
+quote = "1.0.38"

yazi-core/src/manager/commands/rename.rs

@@ -37,22 +37,21 @@ impl Manager {
 			return self.bulk_rename();
 		}
 
-		let Some(hovered) = self.hovered().map(|h| h.url_owned()) else {
-			return;
-		};
-
-		let name = Self::empty_url_part(&hovered, &opt.empty);
+		let Some(hovered) = self.hovered() else { return };
+		let name = Self::empty_url_part(&hovered.url, &opt.empty);
 		let cursor = match opt.cursor.as_ref() {
 			"start" => Some(0),
 			"before_ext" => name
 				.chars()
 				.rev()
 				.position(|c| c == '.')
+				.filter(|_| !hovered.is_dir())
 				.map(|i| name.chars().count() - i - 1)
 				.filter(|&i| i != 0),
 			_ => None,
 		};
 
+		let old = hovered.url_owned();
 		let tab = self.tabs.active().id;
 		tokio::spawn(async move {
 			let mut result = InputProxy::show(InputCfg::rename().with_value(name).with_cursor(cursor));
@@ -64,11 +63,11 @@ impl Manager {
 				return;
 			}
 
-			let new = Url::from(hovered.parent().unwrap().join(name));
-			if opt.force || !maybe_exists(&new).await || paths_to_same_file(&hovered, &new).await {
-				Self::rename_do(tab, hovered, new).await.ok();
+			let new = Url::from(old.parent().unwrap().join(name));
+			if opt.force || !maybe_exists(&new).await || paths_to_same_file(&old, &new).await {
+				Self::rename_do(tab, old, new).await.ok();
 			} else if ConfirmProxy::show(ConfirmCfg::overwrite(&new)).await {
-				Self::rename_do(tab, hovered, new).await.ok();
+				Self::rename_do(tab, old, new).await.ok();
 			}
 		});
 	}