Skip to content

Commit

Permalink
fix(restore): #2445 backup card shown after restore
Browse files Browse the repository at this point in the history
  • Loading branch information
pwltr committed Feb 1, 2025
1 parent b2adc08 commit da893bf
Show file tree
Hide file tree
Showing 10 changed files with 19 additions and 18 deletions.
4 changes: 2 additions & 2 deletions __tests__/todos.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe('Todos selector', () => {
let s: RootState;

beforeAll(async () => {
let res = await createNewWallet();
const res = await createNewWallet();
if (res.isErr()) {
throw res.error;
}
Expand Down Expand Up @@ -67,7 +67,7 @@ describe('Todos selector', () => {

it('should not return backupSeedPhraseTodo if backup is verified', () => {
const state = cloneDeep(s);
state.settings.backupVerified = true;
state.user.backupVerified = true;

expect(todosFullSelector(state)).not.toEqual(
expect.arrayContaining([backupSeedPhraseTodo]),
Expand Down
3 changes: 1 addition & 2 deletions src/screens/Onboarding/RestoreFromSeed.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ import VerticalShadow from '../../components/VerticalShadow';
import Button from '../../components/buttons/Button';
import { useAppDispatch } from '../../hooks/redux';
import { OnboardingStackScreenProps } from '../../navigation/types';
import { verifyBackup } from '../../store/slices/settings';
import { updateUser } from '../../store/slices/user';
import { updateUser, verifyBackup } from '../../store/slices/user';
import {
ScrollView,
TextInput,
Expand Down
2 changes: 1 addition & 1 deletion src/screens/Settings/Backup/BackupPrompt.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import {
} from '../../../hooks/bottomSheet';
import { useAppDispatch, useAppSelector } from '../../../hooks/redux';
import { useBalance } from '../../../hooks/wallet';
import { backupVerifiedSelector } from '../../../store/reselect/settings';
import { viewControllersSelector } from '../../../store/reselect/ui';
import { backupVerifiedSelector } from '../../../store/reselect/user';
import { ignoreBackupTimestampSelector } from '../../../store/reselect/user';
import { closeSheet } from '../../../store/slices/ui';
import { ignoreBackup } from '../../../store/slices/user';
Expand Down
2 changes: 1 addition & 1 deletion src/screens/Settings/Backup/Success.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import SafeAreaInset from '../../../components/SafeAreaInset';
import Button from '../../../components/buttons/Button';
import { useAppDispatch } from '../../../hooks/redux';
import { BackupScreenProps } from '../../../navigation/types';
import { verifyBackup } from '../../../store/slices/settings';
import { verifyBackup } from '../../../store/slices/user';
import { BodyM, BodyMB } from '../../../styles/text';

const imageSrc = require('../../../assets/illustrations/check.png');
Expand Down
4 changes: 0 additions & 4 deletions src/store/reselect/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ export const settingsSelector = (state: RootState): TSettings => state.settings;
const customElectrumPeersState = (state: RootState): TCustomElectrumPeers => {
return state.settings.customElectrumPeers;
};

export const backupVerifiedSelector = (state: RootState): boolean => {
return state.settings.backupVerified;
};
export const selectedCurrencySelector = (state: RootState): string => {
return state.settings.selectedCurrency;
};
Expand Down
7 changes: 5 additions & 2 deletions src/store/reselect/todos.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@ import { ITodo, TTodosState } from '../types/todos';
import { ETransferType, TTransferToSavings } from '../types/wallet';
import { blocktankPaidOrdersFullSelector } from './blocktank';
import { closedChannelsSelector, openChannelsSelector } from './lightning';
import { backupVerifiedSelector, pinSelector } from './settings';
import { pinSelector } from './settings';
import { onboardingProfileStepSelector } from './slashtags';
import { startCoopCloseTimestampSelector } from './user';
import {
backupVerifiedSelector,
startCoopCloseTimestampSelector,
} from './user';
import { createShallowEqualSelector } from './utils';
import { pendingTransfersSelector } from './wallet';

Expand Down
3 changes: 3 additions & 0 deletions src/store/reselect/user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ import { TUser } from '../slices/user';

const userState = (state: RootState): TUser => state.user;

export const backupVerifiedSelector = (state: RootState): boolean => {
return state.user.backupVerified;
};
export const isGeoBlockedSelector = createSelector(
[userState],
(user): boolean => user.isGeoBlocked ?? false,
Expand Down
1 change: 0 additions & 1 deletion src/store/shapes/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ const defaultReceivePreference = [
];

export const initialSettingsState: TSettings = {
backupVerified: false,
enableAutoReadClipboard: false,
enableSendAmountWarning: false,
enableSwipeToHideBalance: true,
Expand Down
5 changes: 0 additions & 5 deletions src/store/slices/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
import { EDenomination, EUnit } from '../types/wallet';

export type TSettings = {
backupVerified: boolean;
enableAutoReadClipboard: boolean;
enableSendAmountWarning: boolean;
enableSwipeToHideBalance: boolean;
Expand Down Expand Up @@ -88,9 +87,6 @@ export const settingsSlice = createSlice({
addOrangeTicket: (state, action: PayloadAction<string>) => {
state.orangeTickets.push(action.payload);
},
verifyBackup: (state) => {
state.backupVerified = true;
},
resetSettingsState: () => initialSettingsState,
},
});
Expand All @@ -103,7 +99,6 @@ export const {
addTreasureChest,
updateTreasureChest,
addOrangeTicket,
verifyBackup,
resetSettingsState,
} = actions;

Expand Down
6 changes: 6 additions & 0 deletions src/store/slices/user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { PayloadAction, createSlice } from '@reduxjs/toolkit';
export const MAX_WARNINGS = 3; // how many times to show high balance warning

export type TUser = {
backupVerified: boolean;
ignoreAppUpdateTimestamp: number;
ignoreBackupTimestamp: number;
ignoreHighBalanceCount: number;
Expand All @@ -19,6 +20,7 @@ export type TUser = {
};

export const initialUserState: TUser = {
backupVerified: false,
ignoreAppUpdateTimestamp: 0,
ignoreBackupTimestamp: 0,
ignoreHighBalanceCount: 0,
Expand Down Expand Up @@ -65,6 +67,9 @@ export const userSlice = createSlice({
ignoreSwitchUnitToast: (state) => {
state.ignoresSwitchUnitToast = true;
},
verifyBackup: (state) => {
state.backupVerified = true;
},
resetUserState: () => initialUserState,
},
});
Expand All @@ -81,6 +86,7 @@ export const {
clearCoopCloseTimer,
ignoreHideBalanceToast,
ignoreSwitchUnitToast,
verifyBackup,
resetUserState,
} = actions;

Expand Down

0 comments on commit da893bf

Please sign in to comment.