add sr_get_module_ds_access API

[tbsuht]

In order to read the owner, group and permissions of a module, this PR adds binding for the sr_get_module_ds_access C function.

I'm not an expert with cffi, so let me know if there are things to improve :)
Do you think returning a tuple from the function is fine or would you expect a dedicated type?

Thanks in advance!

[tbsuht]

I'm not sure about the failing CI tests: is this related to my changes? Seems unrelated, but I'm not sure.
build/temp.linux-x86_64-cpython-312/_libyang.c:578:2: error: #error "This version of libyang bindings only works with libyang 2.x"

[tbsuht]

@rjarry I guess this is because libyang-python is running against the devel branch of libyang, which is already preparing for version 3.x?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.93%. Comparing base (59f456b) to head (fe32b83).

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   66.75%   66.93%   +0.17%     
==========================================
  Files           8        8              
  Lines        1107     1113       +6     
==========================================
+ Hits          739      745       +6     
  Misses        368      368              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tbsuht]

Can you create a new tag once merged or what's the policy?

[rjarry]

Thanks for the changes. One last thing, could you update your commit message following the rules I am putting in place?

#64

In a nutshell, your commit message should look like this:

connection: add sr_get_module_ds_access API

Add a new function to get owner, group and permissions of a module based
on its name.

Signed-off-by: Bagg Tobias (ETAS-DAP/XPC-Fe3) <[email protected]>

Thanks!

[rjarry]

Can you create a new tag once merged or what's the policy?

Yes, I can make a release if you want.

[tbsuht]

Thanks for the changes. One last thing, could you update your commit message following the rules I am putting in place?

#64

In a nutshell, your commit message should look like this:

connection: add sr_get_module_ds_access API

Add a new function to get owner, group and permissions of a module based
on its name.

Signed-off-by: Bagg Tobias (ETAS-DAP/XPC-Fe3) <[email protected]>

Thanks!

Done

[rjarry]

Thanks!

[rjarry]

pypi.org uploads are suspended temporarily.

https://github.com/sysrepo/sysrepo-python/actions/runs/8466165185/job/23194386178#step:9:32

I'll re-run the failed deploy job later.