Merge pull request #5390 from systeminit/feat/converge-return-if-non-…

…unique-keys

feat: add catch in converge for non-unique si-names of components

lib/sdf-server/src/service/v2/management/generate_template.rs

@@ -176,6 +176,17 @@ pub async fn generate_template(
     }
     component_sync_code.push_str(
         r#"
+
+    // Check for duplicate si names in the abscene of component idempotency keys
+    const seenNames = new Set<string>();
+    for (const spec of specs) {
+        const name = _.get(spec, ["properties", "si", "name"]);
+        if (seenNames.has(name)) {
+            throw new Error(`Duplicate properties.si.name found: "${name}", please regenerate the template after fixing the duplicate names or modify the id references in the management function`);
+        }
+        seenNames.add(name);
+    }
+
     return template.converge(currentView, thisComponent, components, specs);
 }
 "#,