link activity to message template #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
reviewed
Feb 21, 2023
There was a problem hiding this comment.
I'm not sure linking from content (activity) to configuration (message template) has any benefit in seeing what exactly got sent to the contact, but including the entire e-mail body would of obviously database sizes. However, that's exactly what Core does with letters and e-mail being sent, so maybe we should re-consider implementing this similarly for birthday greetings, as that's the relevant content at this place.
| "<a href='%1'>%2</a>", | ||
| [ | ||
| 1 => $template_url, | ||
| 2 => E::ts('Click here') |
There was a problem hiding this comment.
How about the template's title instead of a catchy Click here and win a sports car 😄?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smaller parts this time. Ready for review