Merge pull request #24 from systopia/allow-tagged-data-multiple

TaggedDataContainer: Allow `add()` to be called multiple times with the same pair of tag and data pointer

src/Tags/TaggedDataContainer.php

@@ -19,8 +19,6 @@
 
 namespace Systopia\JsonSchema\Tags;
 
-use Systopia\JsonSchema\Exceptions\InvalidArgumentException;
-
 final class TaggedDataContainer implements TaggedDataContainerInterface
 {
     /**
@@ -33,31 +31,42 @@ final class TaggedDataContainer implements TaggedDataContainerInterface
      */
     private array $extra = [];
 
+    /**
+     * {@inheritDoc}
+     */
     public function add(string $tag, string $dataPointer, $data, $extra): void
     {
-        if ($this->has($tag, $dataPointer)) {
-            throw new InvalidArgumentException(sprintf('Data for tag "%s" at "%s" already exists', $tag, $dataPointer));
-        }
-
         $this->data[$tag][$dataPointer] = $data;
         $this->extra[$tag][$dataPointer] = $extra;
     }
 
+    /**
+     * {@inheritDoc}
+     */
     public function get(string $tag, string $dataPointer)
     {
         return $this->data[$tag][$dataPointer] ?? null;
     }
 
+    /**
+     * {@inheritDoc}
+     */
     public function has(string $tag, string $dataPointer): bool
     {
         return \array_key_exists($dataPointer, $this->data[$tag] ?? []);
     }
 
+    /**
+     * {@inheritDoc}
+     */
     public function getAll(): array
     {
         return $this->data;
     }
 
+    /**
+     * {@inheritDoc}
+     */
     public function getByTag(string $tag): array
     {
         return $this->data[$tag] ?? [];
@@ -68,6 +77,9 @@ public function hasTag(string $tag): bool
         return isset($this->data[$tag]);
     }
 
+    /**
+     * {@inheritDoc}
+     */
     public function getExtra(string $tag, string $dataPointer)
     {
         return $this->extra[$tag][$dataPointer] ?? null;

src/Tags/TaggedDataContainerInterface.php

@@ -22,6 +22,10 @@
 interface TaggedDataContainerInterface
 {
     /**
+     * If the method is called multiple times with the same pair of tag and data
+     * pointer, the last data will be available. This might happen e.g. in case
+     * of sub schemas.
+     *
      * @param null|mixed $data
      * @param null|mixed $extra
      */

tests/Tags/TaggedDataContainerTest.php

@@ -20,7 +20,6 @@
 namespace Systopia\JsonSchema\Test\Tags;
 
 use PHPUnit\Framework\TestCase;
-use Systopia\JsonSchema\Exceptions\InvalidArgumentException;
 use Systopia\JsonSchema\Tags\TaggedDataContainer;
 
 /**
@@ -66,9 +65,5 @@ public function test(): void
         self::assertSame(['/foo' => null], $container->getByTag('test2'));
         self::assertTrue($container->has('test2', '/foo'));
         self::assertNull($container->get('test2', '/foo'));
-
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('Data for tag "test" at "/foo" already exists');
-        $container->add('test', '/foo', 'exists', null);
     }
 }