Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore None node in .saved_tensors (It happens in some DGL models). #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore None node in .saved_tensors (It happens in some DGL models). #68

wants to merge 1 commit into from

Conversation

lizeyan
Copy link

@lizeyan lizeyan commented Jul 15, 2021

For DGL, some operators in it (e.g., GSpMMBackward) have None in .save_tensors.
In such cases, make_dot just crashes. So I ignore the Nones in .save_tensors.

albanD
albanD approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks for sending a PR

cc @szagoruyko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizeyan @albanD