new taboola user-id module #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still in progress please don't merge |
shakhaltb
reviewed
Feb 5, 2025
modules/taboolaIdSystem.js
Outdated
| const [match] = cookieData.split('&').filter(item => item.startsWith(`${key}=`)); | ||
| if (match) { | ||
| // eslint-disable-next-line no-unused-vars | ||
| const [_, value] = match.split('='); |
There was a problem hiding this comment.
Suggested change
| const [_, value] = match.split('='); | |
| const value = match.split('=')[1]; |
remove
// eslint-disable-next-line no-unused-vars
ahmadlob
reviewed
Feb 6, 2025
modules/taboolaBidAdapter.js
Outdated
| @@ -277,7 +277,7 @@ function fillTaboolaReqData(bidderRequest, bidRequest, data) { | |||
| const {refererInfo, gdprConsent = {}, uspConsent} = bidderRequest; | |||
| const site = getSiteProperties(bidRequest.params, refererInfo, bidderRequest.ortb2); | |||
| deepSetValue(data, 'device', bidderRequest?.ortb2?.device); | |||
| const extractedUserId = userData.getUserId(gdprConsent, uspConsent); | |||
| const extractedUserId = bidRequest?.userId?.taboolaId ? bidRequest.userId.taboolaId : userData.getUserId(gdprConsent, uspConsent); | |||
There was a problem hiding this comment.
In today's meeting they mentioned this is not needed
There was a problem hiding this comment.
i will remove it
ahmadlob
reviewed
Feb 6, 2025
| * NOTE: We already have query params (?app.type=desktop&app.apikey=...), | ||
| * so we'll handle extra params carefully. | ||
| */ | ||
| const TABOOLA_SYNC_ENDPOINT = 'https://api.taboola.com/1.2/json/taboola-usersync/user.sync?app.type=desktop&app.apikey=e60e3b54fc66bae12e060a4a66536126f26e6cf8'; |
There was a problem hiding this comment.
its part of the endpoint must have parameter, its a dummy api key that we asked to put (hardcoded) in the endpoint url
ahmadlob
reviewed
Feb 6, 2025
| if (!cookieData) { | ||
| return undefined; | ||
| } | ||
| const [match] = cookieData.split('&').filter(item => item.startsWith(`${key}=`)); |
There was a problem hiding this comment.
if (!cookieData) {
return undefined;
}
checking for cookieData being falsy (including undefined, null, empty string, etc.)
isn't it enough ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
added taboola's new user id submodule
Other information