-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
There is one TODO left in PR Maybe wait till 1.5 for generics? Or use another approach as u suggest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I've added some nits from my side.
With that, I summon @Gusarich for a better proof-read of the code :)
@novusnota resolved your comments |
@a-bahdanau @pixelplex Thanks for opening the PR and working through all the suggestions we threw at you :) @Gusarich, thanks for helping me review this! Please notify if there is anything else before we merge it? |
8184e9a
to
953ad85
Compare
Thanks @a-bahdanau, we have a nice starting point to further enhance the cookbook! |
Closes #321